-
Notifications
You must be signed in to change notification settings - Fork 61
Upgrade to Spring Boot 4.0.0-RC1 #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@wimdeblauwe In preparation for the upcoming release of Spring Boot 4.0. The PR is currently still a draft and may be updated once Spring Boot 4.0 is released. |
...ring-boot/src/test/java/io/github/wimdeblauwe/htmx/spring/boot/mvc/HeaderResultMatchers.java
Show resolved
Hide resolved
25286ae to
36434fb
Compare
36434fb to
5e74c05
Compare
|
Thanks for preparing this. Looks good at first sight. I will test once we get to the first release candidate of Spring Boot 4. |
|
@xhaggi I updated the branch for Spring Boot 4.0.0-RC1. Could you fix the merge conflict? After that, I will merge and do a 5.0.0-rc.1 release so people can test with it. |
92ca147 to
ec0f7a8
Compare
ec0f7a8 to
65fae30
Compare
Thank you. I pulled your changes, but all tests in |
.../io/github/wimdeblauwe/htmx/spring/boot/mvc/HtmxResponseHandlerMethodArgumentResolverIT.java
Outdated
Show resolved
Hide resolved
65fae30 to
0cb7a7d
Compare
|
@wimdeblauwe the issues with REST-assured are caused by the upgrade from Groovy 4.x to 5.x in Spring Boot 4. REST-assured relies on Groovy 4.x. |
|
I guess we can go ahead with |
|
Sure, I would recommend it. |
Fixes #174