Handle htmx headers for @ResponseBody methods #183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods For methods annotated with @responsebody (or controllers with @RestController), the response is already commited before the interceptor is invoked, thus the headers won't be written. The ResponseBodyAdvice was added to handle these cases.
wimdeblauwe
approved these changes
Nov 13, 2025
xhaggi
requested changes
Nov 19, 2025
Collaborator
xhaggi
left a comment
xhaggi
left a comment
There was a problem hiding this comment.
Please rebase your branch onto main again.
| public RequestMappingHandlerMapping getRequestMappingHandlerMapping() { | ||
| return new HtmxRequestMappingHandlerMapping(); | ||
| public RequestMappingHandlerAdapter getRequestMappingHandlerAdapter() { | ||
| var adapter = new RequestMappingHandlerAdapter(); |
Collaborator
There was a problem hiding this comment.
Please add back the getRequestMappingHandlerMapping method? Otherwise, the request mapping is broken.
xhaggi
changed the title
xhaggi
changed the title
Collaborator
|
@fchtngr and could you please shorten the commit message |
Owner
|
@fchtngr When would you be able to do the changes? We would like to release a 5.0.0 with this included today or tomorrow. |
xhaggi
added a commit
that referenced
this pull request
Nov 24, 2025
Handle htmx headers for @responsebody methods
Collaborator
|
@fchtngr I made the necessary adjustments and merged it in. Thank you for your contribution. |
Contributor
Author
|
@xhaggi @wimdeblauwe thx, i was away for a few days. thanks for updating and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xhaggi the new PR based off of the main branch (instead 4.x)
see original PR here