Skip to content

fix: "show" not showing Download and Published#1843

Closed
silentJET85 wants to merge 2 commits intowimpysworld:mainfrom
silentJET85:fix-show
Closed

fix: "show" not showing Download and Published#1843
silentJET85 wants to merge 2 commits intowimpysworld:mainfrom
silentJET85:fix-show

Conversation

@silentJET85
Copy link
Copy Markdown
Contributor

closes #1842

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: This PR modifies core logic for data fetching and introduces privilege escalation (elevate_privs) to the 'show' command, which requires human review.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Requires human review: The PR modifies core logic for fetching/caching data and introduces 'elevate_privs' to the 'show' command, which changes permission requirements and requires human validation.

@silentJET85
Copy link
Copy Markdown
Contributor Author

I found another problem. deb-get reinstall also will fail if the CACHE_FILE doesn't already exist. I went ahead and added the fix to this PR as well.

@philclifford
Copy link
Copy Markdown
Member

Oops - fixed by #1848. Sorry I missed your PR.

@philclifford
Copy link
Copy Markdown
Member

philclifford commented Apr 21, 2026

I found another problem. deb-get reinstall also will fail if the CACHE_FILE doesn't already exist. I went ahead and added the fix to this PR as well.

That's not in #1848. I wonder if it is really needed because reinstall should only happen if a package is already installed, in which case the CACHE_FILE should generally exist already. Personally I think the "solution" to users trying to reinstall a package they don't have already installed would be to check in reinstall and either silently call install instead or output a grumpy message telling the user to do that themselves.

I might be wrong ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: "deb-get show" missing info for non-installed packages

2 participants