Skip to content

feat(dev): Add oxlint and a CI workflow for fmt & lint - #777

Open
a5ehren wants to merge 1 commit into
winboat-org:mainfrom
a5ehren:oxfmt
Open

feat(dev): Add oxlint and a CI workflow for fmt & lint#777
a5ehren wants to merge 1 commit into
winboat-org:mainfrom
a5ehren:oxfmt

Conversation

@a5ehren

@a5ehren a5ehren commented May 12, 2026

Copy link
Copy Markdown
Contributor

The project did not have any mechanism to enforce format settings or code quality, so this PR does:

  • Update prettier config to be aware of tailwind CSS
  • Add oxlint with a basic config
  • Fix the issues that fall out of prettier and oxlint against current HEAD
  • Add a CI workflow to check both on all PRs

@a5ehren a5ehren changed the title feat(dev): Add oxfmt and oxlint pre-commit hook feat(dev): Add oxlint and a CI workflow for fmt & lint May 13, 2026

@waffles-dev waffles-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with changes to this one. Leaving final call to @TibixDev - he'll need to set up the branch rule anyway.

Comment thread src/renderer/lib/winboat.ts Outdated

@waffles-dev waffles-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed one, sry

Comment thread src/renderer/lib/winboat.ts Outdated

@waffles-dev waffles-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally happy with changes, I think this helps to improve quality of the project for long term and that this is good to go as-is.
Waiting on feedback from Tibix - he'll have final say on this one.

@waffles-dev waffles-dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the long wait, Tibix has finally gotten around to taking a look - have some minor feedback

Comment thread src/renderer/App.vue Outdated
Comment thread src/main/main.ts Outdated
Comment thread src/renderer/tsconfig.json Outdated
Comment thread .gitignore
Comment thread src/renderer/lib/winboat.ts Outdated
@a5ehren
a5ehren force-pushed the oxfmt branch 2 times, most recently from 1892dd1 to c2af740 Compare July 27, 2026 16:04
@a5ehren

a5ehren commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the noise - rebasing and updating oxlint before addressing the feedback

@a5ehren
a5ehren force-pushed the oxfmt branch 2 times, most recently from cabcafe to 7c8393b Compare July 27, 2026 19:27
@a5ehren
a5ehren requested a review from waffles-dev July 27, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants