-
-
Notifications
You must be signed in to change notification settings - Fork 792
Feature: Add offset functionality to Designer #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've used this icon I've found but not sure if you are using a certain icon collection that cold have more coherence with the application look. |
public static final String PANEL_LAYOUT_CONFIG = "fill, insets 2"; | ||
public static final String SPINNER_COL_CONSTRAINTS = "width 60:100:100, wrap"; | ||
|
||
private JSpinner offsetDistance; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be replaced with a com.willwinder.universalgcodesender.uielements.components.UnitSpinner
at a later time
@@ -0,0 +1,198 @@ | |||
/* | |||
Copyright 2021 Will Winder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should take credit here =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its my first time collaborating to an opensource project xd
thanks to point it, I'll take care in following PRs ;)
Regarding the icons, I have started using Phosphor icons as they are easy to work with: I try to use one color for the original since this makes it easy to convert for dark themes using the script: scripts/svg_to_icons.sh Don't worry about that now, I think it is good enough. |
This PR adds a new offset feature to the Designer module. The offset functionality allows users to create inward or outward offsets from selected shapes, which is particularly useful for creating toolpath offsets, creating shape outlines, or generating insets for shapes.
Features
Implementation details
Usage
The offset feature works with all cuttable entities and preserves the original selection, making it easy to continue working with both the original and offset shapes.