fix(schema): preserve user-defined JSON schema for Python list[dict] parameters #7280
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where JSON schema properties manually defined in the UI are lost when saving Python scripts with list[dict] or untyped array parameters. Changes: - Preserve all items fields (properties, required, additionalProperties, etc.) - Preserve items.type instead of hardcoding "object" - Preserve type for untyped parameters using nullish coalescing - Add type safety check for items preservation The Python parser cannot infer object properties from list[dict] annotations. This fix preserves user-defined schema fields when parser cannot infer structure. Fixes windmill-labs#7209
devdattatalele
requested review from
alpetric,
hugocasa and
rubenfiszel
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Address bot feedback for consistency. The untyped list branch now preserves all user-defined fields (required, additionalProperties, enum, etc.) just like the record[] branch, instead of only preserving properties. This ensures users who define required fields or enum values for untyped list parameters don't lose that data on save. Related to windmill-labs#7209
Contributor
Author
|
Fixed the inconsistency. The untyped list branch now preserves all user-defined fields (required, additionalProperties, enum, resourceType, contentEncoding, description) just like the record[] branch, instead of only preserving properties. This ensures complete schema preservation regardless of whether the list is typed ( |
Contributor
|
@hugocasa could you check please |
hugocasa
reviewed
Dec 9, 2025
| } else { | ||
| newS.type = "object"; | ||
| // Preserve existing type when inference fails, default to "object" for undefined/null | ||
| newS.type = oldS.type ?? "object"; |
Collaborator
There was a problem hiding this comment.
@rubenfiszel are you ok with this? right now we fallback to "object" when we the type can't be parsed
Contributor
There was a problem hiding this comment.
that feels reasonable, but we may want to try how it behave with a few real world examples of typing live and see the result with new behavior and old behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When defining Python scripts with
list[dict]or untyped array parameters, user-defined JSON schema properties are lost upon saving as draft or deploying. This prevents users from creating proper UI forms for complex data structures like message arrays for LLM calls.Resolves #7209
According to comments made following changes
Frontend:
cli/windmill-utils-internal/src/parse/parse-schema.ts:Testing
Test Case 1:
list[dict]with properties and required fieldsTest Case 2: Untyped array parameter
type: "array"with properties via UITest Case 3: Backward compatibility
Breaking Changes
None. This change only preserves user-defined fields when they exist.