-
Notifications
You must be signed in to change notification settings - Fork 855
Type-checked data tables #7381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
diegoimbert
wants to merge
198
commits into
main
Choose a base branch
from
di/typechecked-datatables
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Type-checked data tables #7381
+2,524
−584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
diegoimbert
commented
Dec 15, 2025
- data tables settings ui
- install runed
- zod 4 fixes
- use new toJSONSchema
- Migrate ducklake catalogs to more generic custom instance databases
- fix compilation
- Safety conversion for old duckdb ffi
- data tables settings
- ts client basis
- inline run works
- datatables work
- Revert "datatables work"
- datatables work (without leaking pg credentials)
- println
- separate sqlUtils.ts
- nit
- Separate custom instance db Select and Wizard components
- nit
- nit wording
- add tags to custom instance dbs
- error when trying to use ducklake as datatable or opposite
- show status in dropdown
- data table instance setup works
- sqk function for ducklake
- factorize logic
- fix temp reactivity
- Data table assetexplore
- Migrate S3 permissions to modal
- Revert "Migrate S3 permissions to modal"
- nit query -> fetch
- Custom instance setup new look
- run_language_executor separate fn
- run_inline param
- nit wording
- Better typed client
- Data tables display as assets in frontend
- asset db icon
- nit
- cleaner errors
- nit
- Fix sed calls in mac
- run_inline_script_preview in python client
- basic python datatable client
- datatable and datalake parser in python
- ducklake client python
- nit fix
- Fix migration producing NULL instead of {} when no custom databases
- merge conflict fail
- python ducklake client arg fix
- parse or infer sql types in ts client
- ts asset parser, detect datatable & ducklake R/W
- fix sql repl for other read ops than select
- export type SqlTemplateFunction
- rename list_custom_instance_pg_databases
- typecheck datatable and ducklake name in Typescript
- Fix typecheck datatable and ducklake in TS
- declare module overriding instead of extending
- infer_sql_type in python client
- SqlQuery object in python
- fix merge conflicts
- update const_format
- CI fix
- factor out to var_identifiers
- sqlx prepare
- unnecessary security (admin is required)
- clearer comment
- ee repo ref
- nit snake case
- claude step 1: detect var declarations
- move detect_sql_access_type to common mod
- claude step 2: detect when saved vars are queried
- Revert "claude step 2: detect when saved vars are queried"
- Revert "claude step 1: detect var declarations"
- remove ducklake/datatable and default
- detect data table assigns in var_identifiers
- Python parser successfully infers R/W/RW from ducklake / datatable
- still register ducklake/datatable if not used as unknown R/W
- Go to settings button in Assets Dropdown on not found
- nit
- sqlx prepare fail
- manual fix, somehow sqlx prepare won't do it
- fix frontend ci
- ee repo ref
- ducklake_user doesnt exist in unit tests
- nit fix
- ui nit
- nit
- nit missing clone
- fork ducklakes and datatables
- fix surface hover bug
- stupid mistake
- better deeply reactive mutable derived
- Ducklake picker
- Editor bar data tables
- DuckDB supports datatables
- datatable in duckdb asset parser
- duckdb asset parser var_identifiers
- Revert "duckdb asset parser var_identifiers"
- sqlx prepare
- Box pin in test_workflow_as_code to fix stack overflow
- stash
- sql asset parser parses most s3 literals
- nit
- Detect attach + handle returning RW
- detect assets used with dot notation
- detect implicit access with USE dl; syntax
- Add assets as unknown if var was never used
- Support default ducklake/datatable main in parser
- ignore asset parsing errors in frontend (avoid flow layout shift)
- super weird duplication (merge conflict ?)
- nits
- fix duckdb parser detecting too much as asset when RW ctx is unknown
- fix transparent assets btn
- missing arg
- nit styling
- asset parser specific table parsing
- fix resource specific table parsing
- More concise asset display in flows + better icons
- fix assets page filtering out resources with added table
- Fix frontend to support specific table assets
- Open DB Manager to specific table
- Specific table parser in Python and TS + unit tests
- Fix UPDATE setting access to None
- fix flow edge rendering on top of output picker
- python parser fix var override bug
- add ts test
- fix compilation
- sqlx prepare
- update parsers version
- fix missing schema key onDelete
- Grant permission to create schemas in custom instance databases
- Update pg query to return empty schemas
- Create schema
- Select nits
- support schemas in sql parser
- ts parser handle schema with sql parser result
- detect .schema() syntax
- detect schema syntax in python
- support .schema() in ts and py SDK
- open db manager to specific schema
- support reassignment in ts parser
- nit better unitest
- : syntax in ts
- datatable:schema syntax in python
- fix client py
- nit select dropdown darkmode
- object | null fetchOne
- ts client nits
- parse_sql_client_name fn
- getImportWmillTsStatement refactor in EditorBar
- text to json() in python client
- update parser versions
- pkg lock
- Sql query details in TS asset parser
- code transformation with type parameter in Editor
- Custom Language Worker, code substition works !
- Error marker mapping works
- hover info is correct
- completions work correctly
- other overrides
This reverts commit 6e1588d.
|
Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR. Last updated for commit 09f1419. This comment will update as new commits are pushed. |
Deploying windmill with
|
| Latest commit: |
c90ee64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e801480b.windmill.pages.dev |
| Branch Preview URL: | https://di-typechecked-datatables.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.