WINDUPRULE-945 JavaEE to Quarkus: helloworld-rs migration by mrizzi · Pull Request #1 · windup/jboss-eap-quickstarts

mrizzi · 2023-05-05T12:36:37Z

Rules created from these changes in:

WINDUPRULE-945 JavaEE to Quarkus - JAX-RS, pom.xml setup, CDI, Static Resources windup-rulesets#946

mrizzi · 2023-05-05T14:33:38Z

helloworld-rs/pom.xml

        <relativePath>../pom.xml</relativePath>
    </parent>
    <artifactId>helloworld-rs</artifactId>
-    <packaging>war</packaging>


The expected project artifact's extension is jar
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:38:03Z

helloworld-rs/pom.xml

+    <dependencyManagement>
+        <dependencies>
+            <dependency>
+                <groupId>${quarkus.platform.group-id}</groupId>
+                <artifactId>${quarkus.platform.artifact-id}</artifactId>
+                <version>${quarkus.platform.version}</version>
+                <type>pom</type>
+                <scope>import</scope>
+            </dependency>
+        </dependencies>
+    </dependencyManagement>


Adopt Quarkus BOM
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:38:10Z

helloworld-rs/pom.xml

+        <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
+        <quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id>
+        <quarkus.platform.version>2.16.6.Final</quarkus.platform.version>


Adopt Quarkus BOM
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:39:29Z

helloworld-rs/pom.xml

+            <plugin>
+                <groupId>${quarkus.platform.group-id}</groupId>
+                <artifactId>quarkus-maven-plugin</artifactId>
+                <version>${quarkus.platform.version}</version>
+                <extensions>true</extensions>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>build</goal>
+                            <goal>generate-code</goal>
+                            <goal>generate-code-tests</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>


Adopt Quarkus Maven plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:40:52Z

helloworld-rs/pom.xml

+            <plugin>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <version>${compiler-plugin.version}</version>
+                <configuration>
+                    <compilerArgs>
+                        <arg>-parameters</arg>
+                    </compilerArgs>
+                </configuration>
+            </plugin>


Adopt Maven Compiler plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:41:37Z

helloworld-rs/pom.xml

+            <plugin>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <version>${surefire-plugin.version}</version>
+                <configuration>
+                    <systemPropertyVariables>
+                        <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
+                        <maven.home>${maven.home}</maven.home>
+                    </systemPropertyVariables>
+                </configuration>
+            </plugin>


Adopt Maven Surefire plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:41:54Z

helloworld-rs/pom.xml

+        <quarkus.platform.group-id>io.quarkus.platform</quarkus.platform.group-id>
+        <quarkus.platform.version>2.16.6.Final</quarkus.platform.version>
+        <skipITs>true</skipITs>
+        <surefire-plugin.version>3.0.0</surefire-plugin.version>


Adopt Maven Surefire plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:42:07Z

helloworld-rs/pom.xml

+        <compiler-plugin.version>3.10.1</compiler-plugin.version>
+        <maven.compiler.release>11</maven.compiler.release>


Adopt Maven Compiler plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:43:10Z

helloworld-rs/pom.xml

+            <plugin>
+                <artifactId>maven-failsafe-plugin</artifactId>
+                <version>${surefire-plugin.version}</version>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>integration-test</goal>
+                            <goal>verify</goal>
+                        </goals>
+                        <configuration>
+                            <systemPropertyVariables>
+                                <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path>
+                                <java.util.logging.manager>org.jboss.logmanager.LogManager</java.util.logging.manager>
+                                <maven.home>${maven.home}</maven.home>
+                            </systemPropertyVariables>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>


Adopt Maven Failsafe plugin
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:43:57Z

helloworld-rs/pom.xml

+    <profiles>
+        <profile>
+            <id>native</id>
+            <activation>
+                <property>
+                    <name>native</name>
+                </property>
+            </activation>
+            <properties>
+                <skipITs>false</skipITs>
+                <quarkus.package.type>native</quarkus.package.type>
+            </properties>
+        </profile>
+    </profiles>


Add Maven profile to run the Quarkus native build
https://quarkus.io/guides/maven-tooling#build-tool-maven

mrizzi · 2023-05-05T14:45:55Z

helloworld-rs/pom.xml

-            <groupId>org.jboss.spec.javax.ws.rs</groupId>
-            <artifactId>jboss-jaxrs-api_2.1_spec</artifactId>
-            <scope>provided</scope>
+          <groupId>io.quarkus</groupId>
+          <artifactId>quarkus-resteasy</artifactId>


Replace JAX-RS dependency
https://quarkus.io/guides/resteasy

should use quarkus-resteasy-reactive if possible.

might be edge cases of things in resteasy/jaxrs we don't support but quarkus-resteas-reactive would be recommended if intent is to move forward vs staying more compatible.

mrizzi · 2023-05-05T14:51:31Z

helloworld-rs/pom.xml

-            <groupId>javax.enterprise</groupId>
-            <artifactId>cdi-api</artifactId>
-            <scope>provided</scope>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-arc</artifactId>


Replace javax.enterprise:cdi-api dependency
https://quarkus.io/guides/cdi-reference

mrizzi · 2023-05-05T15:03:30Z

helloworld-rs/src/main/java/org/jboss/as/quickstarts/rshelloworld/HelloService.java

 * @author Pete Muir
 *
 */
+@Dependent


Injected class is missing scope annotation
https://quarkus.io/guides/cdi-reference
https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#default_scope

mrizzi · 2023-05-05T15:03:36Z

helloworld-rs/src/main/java/org/jboss/as/quickstarts/rshelloworld/HelloService.java

 */
 package org.jboss.as.quickstarts.rshelloworld;

+import javax.enterprise.context.Dependent;


Injected class is missing scope annotation
https://quarkus.io/guides/cdi-reference
https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#default_scope

mrizzi · 2023-05-05T15:07:15Z

helloworld-rs/src/main/resources/META-INF/resources/index.html

Static resources
https://quarkus.io/guides/http-reference#serving-static-resources

mrizzi · 2023-05-05T15:16:31Z

helloworld-rs/src/main/webapp/WEB-INF/beans.xml

beans.xml descriptor content is ignored
https://quarkus.io/guides/cdi-reference#limitations

WINDUPRULE-945 JavaEE to Quarkus: helloworld-rs migration

5001313

mrizzi marked this pull request as draft May 5, 2023 12:36

mrizzi commented May 5, 2023

View reviewed changes

mrizzi mentioned this pull request May 5, 2023

WINDUPRULE-945 JavaEE to Quarkus - JAX-RS, pom.xml setup, CDI, Static Resources windup/windup-rulesets#946

Merged

mrizzi mentioned this pull request Jun 1, 2023

WINDUPRULE-945 quarkus3 alias and other feedback implemented windup/windup-rulesets#980

Merged

		<compiler-plugin.version>3.10.1</compiler-plugin.version>
		<maven.compiler.release>11</maven.compiler.release>

Conversation

mrizzi commented May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maxandersen May 31, 2023

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrizzi May 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mrizzi commented May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading

mrizzi May 5, 2023 •

edited

Loading