fix(windows): improve Claude binary detection on Windows - #213
Open
embogomolov wants to merge 2 commits into
Open
fix(windows): improve Claude binary detection on Windows#213embogomolov wants to merge 2 commits into
embogomolov wants to merge 2 commits into
Conversation
- Replace Unix-specific cp -r command with cross-platform Node.js cp() function - Add icon.ico to Tauri bundle configuration to fix Windows bundling These changes enable successful builds on Windows systems
- Use 'where' command on Windows instead of 'which' for proper path resolution - Fix command resolution that incorrectly resolved to bun.exe - Add CREATE_NO_WINDOW flag to hide console windows on Windows - Support multiple paths returned by 'where' command - Use full paths for version detection to avoid binary conflicts Fixes issue where Windows users saw 'Bun v1.2.18' instead of Claude responses and where npm global installations were not detected in settings.
|
works with latest version too |
How are you getting it to work with the latest version with all the mentions of bundles? EDIT: Got it working eventually after a lot of messing with agents.rs and claude_binaries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows-specific issues with Claude binary detection and execution
Changes
Fixes