Closed
Conversation
Update HashByRef to compare data pointers only, enabling identity checks across different lifetime parameters. Update Bencher to support nodes with lifetimes.
Redefine Stream, Node, and MutableNode traits to include a lifetime parameter 'a. Propagate this lifetime through Graph, GraphState, and basic stream operators. Refactor simple library nodes to support non-static data.
Update demux, fold, graph_node (mapper/producer), and async_io to support lifetime 'a. Resolve type mismatches in nested TinyVec streams and ensure proper thread joining in teardown.
Update CSV and Iterator stream adapters to comply with the new lifetime-parameterized Node and Stream traits.
Update PyStream and PyNode to use 'static lifetime for the underlying rust nodes. Use unsafe transmute in upstreams to bridge lifetimes within the Python wrapper boundary.
Update doc-tests and examples to use the new lifetime-parameterized API. Switch most doc-tests to HistoricalMode for reliability.
Contributor
Author
|
Going to stick to node ownership of state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of messy but proves it's possible.