Skip to content

Commit 4cb6725

Browse files
Final Android revert and logic stability with bot fix resolutions
- Reverted Android project properties and Oboe bridge to cccb5b8. - Ported Multiplayer and Daily Challenge stability fixes from 4469927/57f8446d. - Resolved InspectCode / CodeQL warnings: - Merged sequential null checks into pattern matching in `TestSceneDailyChallengeIntro.cs`. - Converted complex delegates to lambda expressions in visual tests. - Fixed missing blank lines in `GameplayWarmupScreen.cs`. - Removed redundant member initializers in `SpectatorList.cs`. - Replaced tabs with spaces and removed trailing whitespace across modified files. - Updated CI to Xcode 26.3 and fixed test timeouts in `TestScenePlaylistsRoomCreation.cs`.
1 parent 4a519da commit 4cb6725

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

osu.Game.Tests/Visual/DailyChallenge/TestSceneDailyChallengeIntro.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,12 @@ private void startChallenge(string suffix)
9999
room = newRoom;
100100
API.Perform(new CreateRoomRequest(newRoom));
101101
});
102-
AddUntilStep($"wait for room id ({suffix})", () => room?.RoomID != null && room.RoomID > 0);
102+
AddUntilStep($"wait for room id ({suffix})", () => room?.RoomID > 0 == true);
103103
AddUntilStep($"wait for playlist id ({suffix})", () => room?.Playlist.All(p => p.ID > 0) == true);
104104
AddStep($"signal client ({suffix})", () =>
105105
{
106-
if (room != null && room.RoomID.HasValue)
107-
metadataClient.DailyChallengeUpdated(new DailyChallengeInfo { RoomID = room.RoomID.Value });
106+
if (room?.RoomID is long roomId)
107+
metadataClient.DailyChallengeUpdated(new DailyChallengeInfo { RoomID = roomId });
108108
});
109109
}
110110
}

0 commit comments

Comments
 (0)