fix: CI errors (CS8619/IDE1006) + merge ppy ppy#37795 (no invite/duel in ranked rooms)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/27570109-9bbd-46a9-bb06-b8e5b4034215

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game.Rulesets.Osu/Difficulty/Evaluators/RhythmEvaluator.cs

@@ -138,7 +138,7 @@ public static double EvaluateDifficultyOf(DifficultyHitObject current)
                             double power = DifficultyCalculationUtils.Logistic(island.Delta, maxValue: 2.75, multiplier: 0.24, midpointOffset: 58.33);
                             effectiveRatio *= Math.Min(3.0 / islandCount.Count, Math.Pow(1.0 / islandCount.Count, power));
 
-                            islandCounts[islandCountIndex] = (islandCount.Island, islandCount.Count);
+                            islandCounts[islandCountIndex] = (islandCount.Island!, islandCount.Count);
                         }
                         else
                         {

osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs

@@ -329,7 +329,7 @@ private void addHitObjectClickFrames(OsuHitObject h, Vector2 startPosition, floa
                         var frame = (OsuReplayFrame)Frames[j];
 
                         // Don't affect frames which stop pressing a button!
-                        if (j < Frames.Count - 1 || ActionsEqual(frame.Actions, previousActions))
+                        if (j < Frames.Count - 1 || actionsEqual(frame.Actions, previousActions))
                         {
                             frame.Actions.Clear();
                             frame.Actions.Add(action);
@@ -394,7 +394,7 @@ private void addHitObjectClickFrames(OsuHitObject h, Vector2 startPosition, floa
                 AddFrameToReplay(endFrame);
         }
 
-        private static bool ActionsEqual(List<OsuAction> a, List<OsuAction> b)
+        private static bool actionsEqual(List<OsuAction> a, List<OsuAction> b)
         {
             if (a.Count != b.Count) return false;
             for (int i = 0; i < a.Count; i++)

osu.Game/Screens/OnlinePlay/Matchmaking/Queue/QueueController.cs

@@ -89,6 +89,9 @@ public void LeaveQueue()
 
         public void IssueDuel(MatchmakingPool pool, int userId)
         {
+            if (client.Room?.Settings.MatchType.IsMatchmakingType() == true)
+                return;
+
             lastDuelUser = userId;
             lastDuelPool = pool;
 

osu.Game/Users/UserPanel.cs

@@ -23,6 +23,7 @@
 using osu.Game.Online.Chat;
 using osu.Game.Online.Metadata;
 using osu.Game.Online.Multiplayer;
+using osu.Game.Online.Rooms;
 using osu.Game.Overlays;
 using osu.Game.Resources.Localisation.Web;
 using osu.Game.Screens;
@@ -210,9 +211,9 @@ public MenuItem[] ContextMenuItems
                 return items.ToArray();
 
                 bool isUserOnline() => metadataClient?.GetPresence(User.OnlineID) != null;
-                bool canInviteUser() => isUserOnline() && multiplayerClient?.Room?.Users.All(u => u.UserID != User.Id) == true;
+                bool canInviteUser() => isUserOnline() && multiplayerClient?.Room?.Users.All(u => u.UserID != User.Id) == true && multiplayerClient?.Room?.Settings.MatchType.IsMatchmakingType() != true;
                 bool isUserBlocked() => api.LocalUserState.Blocks.Any(b => b.TargetID == User.OnlineID);
-                bool canDuelUser() => isUserOnline() && queueController?.SelectedPool.Value != null;
+                bool canDuelUser() => isUserOnline() && queueController?.SelectedPool.Value != null && multiplayerClient?.Room?.Settings.MatchType.IsMatchmakingType() != true;
             }
         }