fix: address InspectCode CI errors, warnings, and notes (second batch)

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/2e17044b-3164-4e7a-92ca-38cb1bb9eece

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>

Author: Copilot

osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs

@@ -824,9 +824,9 @@ public void TestDecodeFileWithContentImmediatelyAfterHeader()
         [Test]
         public void TestDecodeEmptyFile()
         {
-            using var resStream = new MemoryStream();
             Assert.Throws<IOException>(() =>
             {
+                using var resStream = new MemoryStream();
                 using var stream = new LineBufferedReader(resStream);
                 Decoder.GetDecoder<Beatmap>(stream);
             });

osu.Game/Screens/Edit/Components/FormSampleSet.cs

@@ -274,10 +274,8 @@ private void updateState()
 
                 recycleSamples();
 
-                if (triangles == null)
-                    return;
-
-                triangles.Colour = ColourInfo.GradientVertical(triangleGradientSecondColour ?? default, BackgroundColour);
+                if (triangles != null)
+                    triangles.Colour = ColourInfo.GradientVertical(triangleGradientSecondColour ?? default, BackgroundColour);
             }
 
             private void recycleSamples() => Schedule(() =>

osu.Game/Screens/OnlinePlay/Matchmaking/Queue/RatingDistributionGraph.cs

@@ -725,9 +725,9 @@ public void SetContent(RatingDistributionGraphTooltipData content)
                 valueText.Text = content.Value;
             }
 
-            public void Move(System.Numerics.Vector2 pos)
+            public void Move(Vector2 pos)
             {
-                pos = Parent!.ToLocalSpace(content.Position) - new System.Numerics.Vector2(DrawWidth + 10, 0);
+                pos = Parent!.ToLocalSpace(content.Position) - new Vector2(DrawWidth + 10, 0);
 
                 if (instantMove)
                 {

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Components/RankedPlayStageDisplay.cs

@@ -197,7 +197,6 @@ private void load()
             };
         }
 
-
         protected override void LoadComplete()
         {
             base.LoadComplete();

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/GameplayWarmupScreen.cs

@@ -11,7 +11,6 @@
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.Shapes;
 using osu.Framework.Localisation;
-
 using osu.Game.Beatmaps;
 using osu.Game.Database;
 using osu.Game.Graphics.Containers;

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/PlayerHandOfCards.PlayerHandCard.cs

@@ -99,7 +99,7 @@ private void updatePlayButtonVisibility()
                 PlayButton.Alpha = PlayButton.Action != null && Selected ? 1 : 0;
             }
 
-            public override bool ReceivePositionalInputAt(System.Numerics.Vector2 screenSpacePos)
+            public override bool ReceivePositionalInputAt(Vector2 screenSpacePos)
             {
                 if (PlayButton.Alpha > 0)
                     return fullInputArea.ReceivePositionalInputAt(screenSpacePos);

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/OpponentPickScreen.cs

@@ -153,7 +153,6 @@ private void cardPlayed(RankedPlayCardWithPlaylistItem item) => Task.Run(async (
 
             Schedule(() =>
             {
-
                 if (opponentHand.RemoveCard(item, out var card, out var drawQuad))
                 {
                     card.MatchScreenSpaceDrawQuad(drawQuad, CenterRow);

osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/PickScreen.cs

@@ -270,7 +270,6 @@ private void onPlayButtonClicked()
 
         private void cardPlayed(RankedPlayCardWithPlaylistItem item)
         {
-
             if (playerHand.RemoveCard(item, out var card, out var drawQuad))
             {
                 card.MatchScreenSpaceDrawQuad(drawQuad, CenterRow);

osu.Game/Screens/Play/GameplayMenuOverlay.cs

@@ -39,7 +39,7 @@ public abstract partial class GameplayMenuOverlay : OverlayContainer, IKeyBindin
 
         protected override bool BlockScrollInput => false;
 
-        public override bool ReceivePositionalInputAt(System.Numerics.Vector2 screenSpacePos) => true;
+        public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) => true;
 
         public Action? OnResume { get; init; }
         public Action? OnRetry { get; init; }

osu.Game/Screens/Play/HUD/ArgonSongProgressBar.cs

@@ -19,7 +19,7 @@ namespace osu.Game.Screens.Play.HUD
     public partial class ArgonSongProgressBar : SongProgressBar, IHasTooltip
     {
         // Parent will handle restricting the area of valid input.
-        public override bool ReceivePositionalInputAt(System.Numerics.Vector2 screenSpacePos) => true;
+        public override bool ReceivePositionalInputAt(Vector2 screenSpacePos) => true;
 
         private readonly float barHeight;
 
@@ -139,6 +139,7 @@ protected override void Update()
             audioBar.Length = (float)Interpolation.Lerp(audioBar.Length, AudioProgress, Math.Clamp(Time.Elapsed / 40, 0, 1));
 
             bool shouldBeBehind = trackTime > AudioTime;
+
             if (shouldBeBehind != audioBarBehindPlayfieldBar)
             {
                 audioBarBehindPlayfieldBar = shouldBeBehind;