Fix Oboe audio silence and optimize latency on Android - #128
Conversation
- Implemented 'Hijack & Restore' in OboeAudioRedirector.cs to temporarily detach BASS mixers from framework parents before redirecting to Oboe. This fixes the BASS_ERROR_ALREADY silence and allows clean toggling. - Added recursive root mixer discovery to capture all game audio (UI/SFX/Music) and bypass the framework's final output stage for lower latency. - Explicitly disabled BASS-internal buffering on the master mixer to achieve the lowest possible output latency. - Added restoreDefaultAudio() on refresh to ensure state consistency.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR fixes the issue where audio goes silent when 'Low latency audio (Oboe)' is enabled.
The root cause was that BASS only allows a channel to be a source for a single parent mixer at a time. Since the framework's mixers are already attached to a master mixer, the redirection call was failing with BASS_ERROR_ALREADY.
Key changes:
PR created automatically by Jules for task 5876186882729675120 started by @winnerspiros