fix(android/vulkan): fix rotated/tiled rendering on portrait Android devices — bump osu-framework to 2026.503.1 - #292
Merged
Conversation
… fix) Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/6d8b2d97-6416-4955-9f76-204aefed8e4d Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
May 2, 2026 22:10
View session
winnerspiros
marked this pull request as ready for review
May 2, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulkan on Android rendered with 90° rotation, tiled/duplicated backgrounds, and garbled UI on portrait-panel devices (Adreno 740, e.g. Galaxy S23 Ultra class).
Root cause
winnerspiros/veldridPR #18 setswapchainCi.preTransform = surfaceCapabilities.currentTransform(e.g.Rotate90KHR) to fix a black screen. This tells the compositor "I've already pre-rotated my content" — but Veldrid never applies an inverse rotation matrix to the scene. The hardware display controller then rotates again on top of an already-unrotated frame, producing the corruption visible in the screenshots.The black screen that PR #18 "fixed" was actually caused by four separate Adreno 740 driver bugs — all since fixed independently (MAILBOX stalls, oversized texture-update batches, fragment shading rate SIGSEGV, push descriptor null pointer). With those resolved,
preTransform = IDENTITYis correct and the compositor handles rotation transparently.Fix (in
winnerspiros/veldrid, veldrid commitb5c3cb2)This PR
Bumps
ppy.osu.Framework/.Android/.iOSfrom2026.502.4→2026.503.1(osu-framework pack run #23, commit02acb26d), which vendors the corrected veldrid.osu.Game/osu.Game.csproj—ppy.osu.Frameworkosu.Android.props—ppy.osu.Framework.Androidosu.iOS.props—ppy.osu.Framework.iOS