Skip to content

Fix iOS trim analyzer warnings and Android 16KB ELF page alignment - #108

Merged
winnerspiros merged 16 commits into
masterfrom
copilot/upgrade-project-to-latest-net
Mar 27, 2026
Merged

Fix iOS trim analyzer warnings and Android 16KB ELF page alignment#108
winnerspiros merged 16 commits into
masterfrom
copilot/upgrade-project-to-latest-net

Fix Android build: add file locking to ELF patcher + restore XA0141 s…

34ff418
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode failed Mar 27, 2026 in 5s

70 new alerts including 4 errors

New alerts in code changed by this pull request

  • 4 errors
  • 21 warnings
  • 45 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 4 in osu.Game.Tests/Visual/UserInterface/TestSceneModPresetColumn.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Error test

Using directive is not required by the code and can be safely removed

Check failure on line 4 in osu.Game/Screens/Select/PanelBeatmapSet.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Error

Using directive is not required by the code and can be safely removed

Check failure on line 5 in osu.Game/Online/API/Requests/Responses/APIMenuContent.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Error

Using directive is not required by the code and can be safely removed

Check failure on line 5 in osu.Game/Screens/Menu/MainMenuButton.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant using directive Error

Using directive is not required by the code and can be safely removed

Check warning on line 92 in osu.Game/IO/HardLinkHelper.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 59 in osu.Game/Online/Chat/MessageFormatter.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect indent: Incorrect indent size Warning

Indent size is incorrect, expected indent 15 spaces

Check warning on line 8 in osu.Game/Online/Rooms/PlaylistExtensions.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 0 instead of 1

Check warning on line 45 in osu.Game/Overlays/Chat/ChatLine.cs

See this annotation in the file changed.

Code scanning / InspectCode

Member initialized value ignored Warning

Property initializer value ignored during initialization

Check warning on line 64 in osu.Game/Overlays/Settings/Sections/Input/KeyBindingRow.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 60 in osu.Game/Rulesets/Edit/EditorTimestampParser.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 138 in osu.Game/Rulesets/Mods/Mod.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect indent: Incorrect indent size Warning

Indent size is incorrect, expected indent 14 spaces

Check warning on line 436 in osu.Game/Rulesets/UI/Playfield.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 106 in osu.Game/Rulesets/UI/RulesetInputManager.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 434 in osu.Game/Screens/Edit/Compose/Components/Timeline/SamplePointPiece.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect indent: Incorrect indent size Warning

Indent size is incorrect, expected indent 4 spaces

Check warning on line 123 in osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/OpponentPickScreen.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Incorrect number of blank lines near braces Warning

Incorrect number of blank lines near braces, expected maximum 0 instead of 1

Check warning on line 228 in osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/PickScreen.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Incorrect number of blank lines near braces Warning

Incorrect number of blank lines near braces, expected maximum 0 instead of 1

Check warning on line 597 in osu.Game/Screens/Play/Player.cs

See this annotation in the file changed.

Code scanning / InspectCode

'??' condition is known to be null or not null Warning

'??' left operand is never 'null'

Check warning on line 598 in osu.Game/Screens/Play/Player.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are missing elsewhere Warning

Blank lines are missing, expected minimum 1 instead of 0

Check warning on line 9 in osu.Game/Utils/HumanizerUtils.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect blank lines: Blank lines are redundant elsewhere Warning

Blank lines are redundant, expected maximum 1 instead of 2

Check warning on line 375 in osu.Desktop/NVAPI.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect indent: Missing indent/outdent elsewhere Warning

Line is not indented relative to the previous line, expected indent 4 spaces

Check warning on line 139 in osu.Game.Tournament/Screens/Drawings/Components/ScrollingTeamContainer.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant argument passed to caller argument expression parameter Warning

The parameter 'message' has 'CallerArgumentExpression' attribute applied, so argument could be omitted

Check warning on line 26 in osu.Game.Tournament/Screens/Gameplay/Components/TeamScoreDisplay.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 279 in osu.Game/Beatmaps/WorkingBeatmap.cs

See this annotation in the file changed.

Code scanning / InspectCode

'??' condition is known to be null or not null Warning

'??' left operand is never 'null'

Check warning on line 24 in osu.Game/Extensions/TypeExtensions.cs

See this annotation in the file changed.

Code scanning / InspectCode

Variable can be declared as non-nullable Warning

'assemblyQualifiedName' can be declared as non-nullable

Check warning on line 32 in osu.Game/Graphics/UserInterface/OsuCheckbox.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing