Fix Android Oboe Build Errors and Modernize Audio Path - #116
Conversation
- Update Oboe to latest commit (39b1fd2) in CMakeLists.txt. - Replace deprecated oboe::Process manual affinity settings with modern ADPF (Android Dynamic Performance Framework) support in oboe_bridge.cpp. - Add explicit low-latency flags (setChannelConversionAllowed, setFormatConversionAllowed) to the native bridge. - Fix unboxing errors in OboeAudioRedirector.cs by using robust reflection for BASS mixer handles. - Prevent duplicated audio by ensuring Oboe only outputs data if BASS mixers were successfully silenced.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR resolves the Android build failure caused by missing
oboe::Processmembers in newer Oboe versions. It also modernizes the Oboe integration and addresses runtime issues reported by the user.Key changes:
oboe::Process) and replaced it with Oboe's built-in support for the Android Dynamic Performance Framework (ADPF) viasetPerformanceHintEnabled(true).setChannelConversionAllowed(false)andsetFormatConversionAllowed(false)to the audio stream builder to minimize internal overhead.OboeAudioRedirector.csby implementing a more flexible handle retrieval for BASS mixers that handles multiple names and underlying types (int, long, IntPtr).PR created automatically by Jules for task 987678893198290718 started by @winnerspiros