Fix Oboe build error and address -Ofast warning - #117
Conversation
- Updated Oboe library from a 2023 commit to version 1.10.0 in `osu.Android/Native/CMakeLists.txt`. - This resolves the "no member named 'setPerformanceHintEnabled' in 'oboe::AudioStreamBuilder'" error in `oboe_bridge.cpp`. - Added a CMake patch to replace the deprecated `-Ofast` compiler flag with `-O3 -ffast-math` in the Oboe library target. - Verified that Oboe 1.10.0 supports the ADPF (Android Dynamic Performance Framework) features used in the codebase.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I have fixed the build error related to the Oboe audio library on Android.
The issue was that the
oboe::AudioStreamBuilderclass was missing thesetPerformanceHintEnabledmethod because the Oboe library was pinned to an older 2023 commit inosu.Android/Native/CMakeLists.txt. This method was added in Oboe 1.7.0, so updating to version 1.10.0 (as requested) resolves the error.Additionally, I addressed the deprecation warning for the
-Ofastcompiler flag. Since this flag is set within Oboe's own CMake files, I added a patch in ourCMakeLists.txtto replace-Ofastwith-O3 -ffast-math(which Clang recommends for the same behavior) in the Oboe library target after it is fetched.Changes:
osu.Android/Native/CMakeLists.txtto fetch Oboe 1.10.0.COMPILE_OPTIONSto replace-Ofast.PR created automatically by Jules for task 2029913451270939480 started by @winnerspiros