Fix Android build errors and upgrade to API 33 - #132
Conversation
…'byte' type. - Defined 'byte' as 'uint8_t' in oboe_bridge.cpp to match P/Invoke signatures and fix compilation errors. - Upgraded Android minimum SDK to 33 across all Android projects and manifests. - Updated SupportedOSPlatformVersion to 33.0 in osu.Android.props. - Updated GitHub Actions CI/Release workflows to use android-33 platform for native builds. - This enables use of the APerformanceHint (ADPF) API for 1000 FPS optimizations on supported devices.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Define 'byte' as 'uint8_t' in oboe_bridge.cpp to fix compilation errors. - Upgrade Android targets to API 33 to support ADPF APIs. - Fix CA1401 by changing native bridge externs to internal. - Fix IDE0031 by simplifying null checks in RankedPlayChatDisplay. - Update GitHub Workflows to use android-33 platform.
1 participant
This PR fixes the Android build failures by upgrading the minimum SDK to 33 to support ADPF APIs and defining the missing 'byte' type in the native Oboe bridge.
The upgrade to API 33 allows the project to use the Android Dynamic Performance Framework (ADPF) for high-frequency game loop reporting, which was previously failing due to API unavailability in the android-31 target.
Additionally, the 'byte' type definition in oboe_bridge.cpp ensures that the native exports correctly interface with the managed OboeAudioBridge.cs without relying on external Vulkan headers.
PR created automatically by Jules for task 7936082054627688032 started by @winnerspiros