Fix Android trimming crash and warnings - #164
Merged
winnerspiros merged 4 commits intoApr 7, 2026
Merged
Conversation
- Resolves build failures in .NET 10 by correctly suppressing reflection warnings in OsuGameAndroid.cs and OboeAudioRedirector.cs. - Suppresses several IL2026 and IL2067 warnings in osu.Game identified in build logs. - Strengthens Linker.xml to preserve all main ruleset assemblies and core game hierarchies to ensure runtime stability.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Resolves fatal ILLink crash (IL1012) by correctly suppressing reflection analysis in OsuGameAndroid.cs and OboeAudioRedirector.cs. - Fixes IDE0005/IDE0055 code quality issues by removing unnecessary usings and correcting indentation in LegacyScoreDecoder.cs. - Fixes 'Sequence contains no elements' failure in DailyChallenge tests by preserving Room and PlaylistItem types in Linker.xml. - Strengthens Linker.xml with explicit preservation for all main ruleset assemblies and core game hierarchies to ensure a working APK. - Correctly silences IL2026/IL2067 warnings in osu.Game using UnconditionalSuppressMessage.
- Resolves fatal ILLink crash (IL1012) by correctly suppressing reflection analysis in OsuGameAndroid.cs and OboeAudioRedirector.cs. - Fixes IDE0005/IDE0055 code quality issues by removing unnecessary usings and correcting indentation in APIAccess.cs, APIRequest.cs, and LegacyScoreDecoder.cs. - Fixes 'Sequence contains no elements' failure in DailyChallenge tests and other multiplayer test timeouts by preserving Room, PlaylistItem, APIUser, and ScoreInfo types in Linker.xml. - Strengthens Linker.xml with explicit preservation for all main ruleset assemblies and core game hierarchies to ensure a working APK. - Correctly silences IL2026/IL2067 warnings in osu.Game using UnconditionalSuppressMessage.
- Resolves fatal ILLink crash (IL1012) by correctly suppressing reflection analysis in OsuGameAndroid.cs and OboeAudioRedirector.cs. - Fixes IDE0005/IDE0055 code quality issues by removing unnecessary usings and correcting indentation/line endings in APIAccess.cs, APIRequest.cs, and LegacyScoreDecoder.cs. - Fixes 'Sequence contains no elements' failure in DailyChallenge tests and other multiplayer test timeouts by preserving Room, PlaylistItem, APIUser, and ScoreInfo types in Linker.xml. - Strengthens Linker.xml with explicit preservation for all main ruleset assemblies and core game hierarchies to ensure a working APK. - Correctly silences IL2026/IL2067 warnings in osu.Game using UnconditionalSuppressMessage. - Standardized file encodings and line endings (CRLF + BOM) for modified files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the fatal ILLink crash IL1012 by adding missing [UnconditionalSuppressMessage] attributes to reflection-heavy methods in OsuGameAndroid.cs and OboeAudioRedirector.cs. Also suppresses several IL2026 and IL2067 warnings in osu.Game related to Newtonsoft.Json, dynamic binding, and Activator.CreateInstance. Significantly expands Linker.xml to preserve all main ruleset assemblies (Osu, Taiko, Catch, Mania) and core game hierarchies (Mods, RulesetInfo, RulesetStore) to ensure the APK is functional at runtime.
PR created automatically by Jules for task 11578606248021965789 started by @winnerspiros