a

osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuHitObject.cs

@@ -141,6 +141,7 @@ public virtual void Shake() { }
         /// </summary>
         public void MissForcefully() => ApplyMinResult();
 
+        // ReSharper disable once FunctionRecursiveOnAllPaths (TODO: remove after fixed https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
         private RectangleF parentScreenSpaceRectangle => ((DrawableOsuHitObject)ParentHitObject)?.parentScreenSpaceRectangle ?? Parent!.ScreenSpaceDrawQuad.AABBFloat;
 
         /// <summary>

osu.Game.Rulesets.Osu/Skinning/Default/TrianglesPiece.cs

@@ -9,12 +9,12 @@ namespace osu.Game.Rulesets.Osu.Skinning.Default
     public partial class TrianglesPiece : Triangles
     {
         protected override bool CreateNewTriangles => false;
-        protected override float SpawnRatio => 0.5f;
 
         public TrianglesPiece(int? seed = null)
             : base(seed)
         {
             TriangleScale = 1.2f;
+            SpawnRatio = 0.5f;
             HideAlphaDiscrepancies = false;
             ClampAxes = Axes.None;
         }

osu.Game.Tests/Beatmaps/TestSceneBeatmapDifficultyCache.cs

@@ -65,6 +65,7 @@ public void SetUpSteps()
         }
 
         [Test]
+        [FlakyTest] // one fix attempted in https://github.com/ppy/osu/pull/37178, didn't work
         public void TestInvalidationFlow()
         {
             BeatmapInfo postEditBeatmapInfo = null;

osu.Game.Tests/Database/BackgroundDataStoreProcessorTests.cs

@@ -187,6 +187,7 @@ public void TestScoreUpgradeFailed(int scoreVersion)
         }
 
         [Test]
+        [FlakyTest]
         public void TestCustomRulesetScoreNotSubjectToUpgrades([Values] bool available)
         {
             RulesetInfo rulesetInfo = null!;

osu.Game.Tests/Visual/Editing/TestSceneEditorSaving.cs

@@ -128,6 +128,7 @@ public void TestHitObjectPlacement()
         }
 
         [Test]
+        [FlakyTest]
         public void TestLengthAndStarRatingUpdated()
         {
             WorkingBeatmap working = null;

osu.Game.Tests/Visual/Editing/TestSceneLocallyModifyingOnlineBeatmaps.cs

@@ -24,6 +24,7 @@ public override void SetUpSteps()
         }
 
         [Test]
+        [FlakyTest]
         public void TestLocallyModifyingOnlineBeatmap()
         {
             string initialHash = string.Empty;

osu.Game.Tests/Visual/Editing/TestSceneOpenEditorTimestamp.cs

@@ -4,7 +4,6 @@
 using System.Linq;
 using NUnit.Framework;
 using osu.Framework.Extensions;
-using osu.Framework.Extensions.ObjectExtensions;
 using osu.Framework.Testing;
 using osu.Game.Beatmaps;
 using osu.Game.Database;
@@ -140,14 +139,16 @@ private void assertMovedScreenTo(EditorScreenMode screen, string text = "moved t
 
         private void setUpEditor(RulesetInfo ruleset)
         {
-            BeatmapSetInfo beatmapSet = null!;
+            BeatmapSetInfo? beatmapSet = null;
 
             AddStep("Import test beatmap", () =>
                 Game.BeatmapManager.Import(TestResources.GetTestBeatmapForImport()).WaitSafely()
             );
-            AddStep("Retrieve beatmap", () =>
-                beatmapSet = Game.BeatmapManager.QueryBeatmapSet(set => !set.Protected).AsNonNull().Value.Detach()
-            );
+            AddUntilStep("Retrieve beatmap", () =>
+            {
+                beatmapSet = Game.BeatmapManager.QueryBeatmapSet(set => !set.Protected)?.Value.Detach();
+                return beatmapSet != null;
+            });
             AddStep("Present beatmap", () => Game.PresentBeatmap(beatmapSet));
             AddUntilStep("Wait for song select", () =>
                 Game.Beatmap.Value.BeatmapSetInfo.Equals(beatmapSet)
@@ -157,7 +158,7 @@ private void setUpEditor(RulesetInfo ruleset)
             AddStep("Switch ruleset", () => Game.Ruleset.Value = ruleset);
             AddStep("Open editor for ruleset", () =>
                 ((SoloSongSelect)Game.ScreenStack.CurrentScreen)
-                .Edit(beatmapSet.Beatmaps.Last(beatmap => beatmap.Ruleset.Name == ruleset.Name))
+                .Edit(beatmapSet!.Beatmaps.Last(beatmap => beatmap.Ruleset.Name == ruleset.Name))
             );
             AddUntilStep("Wait for editor open", () => editor?.ReadyForUse == true);
         }

osu.Game.Tests/Visual/Gameplay/TestSceneGameplaySamplePlayback.cs

@@ -20,7 +20,7 @@ public partial class TestSceneGameplaySamplePlayback : PlayerTestScene
         private bool seek;
 
         [Test]
-        [FlakyTest]
+        [Ignore("Still failing even with [FlakyTest] applied.")]
         public void TestAllSamplesStopDuringSeek()
         {
             DrawableSlider? slider = null;

osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayer.cs

@@ -662,7 +662,7 @@ public void TestLeaveNavigation()
 
             AddStep("invoke on back button", () => multiplayerComponents.OnBackButton());
 
-            AddAssert("mod overlay is hidden", () => this.ChildrenOfType<MultiplayerUserModSelectOverlay>().Single().State.Value == Visibility.Hidden);
+            AddAssert("mod overlay is hidden", () => this.ChildrenOfType<MultiplayerUserModSelectOverlay>().All(o => o.State.Value == Visibility.Hidden));
 
             AddAssert("dialog overlay is hidden", () => DialogOverlay.State.Value == Visibility.Hidden);
 

osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

@@ -653,6 +653,7 @@ public void TestDeleteAllScoresAfterPlaying()
         }
 
         [Test]
+        [FlakyTest]
         public void TestDeleteScoreAfterPlaying()
         {
             playToResults();

osu.Game.Tests/Visual/Online/TestSceneFriendDisplay.cs

@@ -12,7 +12,6 @@
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Testing;
-using osu.Game.Graphics.UserInterface;
 using osu.Game.Online.API;
 using osu.Game.Online.API.Requests.Responses;
 using osu.Game.Online.Metadata;
@@ -219,13 +218,13 @@ public void TestLoadFriendsBeforeDisplay()
         }
 
         private void waitForLoad()
-            => AddUntilStep("wait for panels to load", () => this.ChildrenOfType<LoadingSpinner>().First().State.Value, () => Is.EqualTo(Visibility.Hidden));
+            => AddUntilStep("wait for panels to load", () => this.ChildrenOfType<UserPanel>().Any());
 
         private void assertVisiblePanelCount<T>(int expectedVisible)
             where T : UserPanel
         {
-            AddAssert($"{typeof(T).ReadableName()}s in list", () => this.ChildrenOfType<FriendsList>().Last().ChildrenOfType<UserPanel>().All(p => p is T));
-            AddAssert($"{expectedVisible} panels visible", () => this.ChildrenOfType<FriendsList>().Last().ChildrenOfType<FriendsList.FilterableUserPanel>().Count(p => p.IsPresent),
+            AddUntilStep($"{typeof(T).ReadableName()}s in list", () => this.ChildrenOfType<FriendsList>().Last().ChildrenOfType<UserPanel>().All(p => p is T));
+            AddUntilStep($"{expectedVisible} panels visible", () => this.ChildrenOfType<FriendsList>().Last().ChildrenOfType<FriendsList.FilterableUserPanel>().Count(p => p.IsPresent),
                 () => Is.EqualTo(expectedVisible));
         }
 

osu.Game.Tests/Visual/Online/TestSceneUserProfileMatchmakingStatsDisplay.cs

@@ -0,0 +1,89 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Allocation;
+using osu.Framework.Bindables;
+using osu.Framework.Graphics;
+using osu.Framework.Graphics.Shapes;
+using osu.Framework.Testing;
+using osu.Game.Online.API.Requests.Responses;
+using osu.Game.Overlays;
+using osu.Game.Overlays.Profile;
+using osu.Game.Overlays.Profile.Header.Components;
+using osu.Game.Rulesets.Osu;
+using osuTK;
+
+namespace osu.Game.Tests.Visual.Online
+{
+    public partial class TestSceneUserProfileMatchmakingStatsDisplay : OsuManualInputManagerTestScene
+    {
+        [Cached]
+        private readonly Bindable<UserProfileData?> userProfileData = new Bindable<UserProfileData?>(new UserProfileData(new APIUser(), new OsuRuleset().RulesetInfo));
+
+        [Cached]
+        private OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Pink);
+
+        [SetUpSteps]
+        public void SetUpSteps()
+        {
+            AddStep("create", () =>
+            {
+                Clear();
+                Add(new Box
+                {
+                    RelativeSizeAxes = Axes.Both,
+                    Colour = colourProvider.Background2,
+                });
+                Add(new MatchmakingStatsDisplay
+                {
+                    Anchor = Anchor.Centre,
+                    Origin = Anchor.Centre,
+                    Scale = new Vector2(1f),
+                    User = { BindTarget = userProfileData },
+                });
+            });
+
+            AddStep("set stats", () => userProfileData.Value = new UserProfileData(new APIUser
+            {
+                MatchmakingStatistics =
+                [
+                    new APIUserMatchmakingStatistics
+                    {
+                        Plays = 10,
+                        FirstPlacements = 8,
+                        Rank = 1000,
+                        Rating = 2000,
+                        TotalPoints = 500,
+                        Pool =
+                        {
+                            Name = "Active Pool"
+                        }
+                    },
+                    new APIUserMatchmakingStatistics
+                    {
+                        Plays = 5,
+                        FirstPlacements = 4,
+                        Rank = 500,
+                        Rating = 1000,
+                        TotalPoints = 250,
+                        Pool =
+                        {
+                            Name = "Inactive Pool"
+                        }
+                    },
+                    new APIUserMatchmakingStatistics
+                    {
+                        Rating = 1500,
+                        IsRatingProvisional = true,
+                        Pool =
+                        {
+                            Name = "Provisional"
+                        }
+                    }
+                ]
+            }, new OsuRuleset().RulesetInfo));
+
+            AddStep("clear stats", () => userProfileData.Value = null);
+        }
+    }
+}

osu.Game.Tests/Visual/Online/TestSceneUserSearchDisplay.cs

@@ -0,0 +1,24 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using NUnit.Framework;
+using osu.Framework.Allocation;
+using osu.Game.Overlays;
+using osu.Game.Overlays.Dashboard.UserSearch;
+
+namespace osu.Game.Tests.Visual.Online
+{
+    public partial class TestSceneUserSearchDisplay : OsuTestScene
+    {
+        [Cached]
+        private readonly OverlayColourProvider colourProvider = new OverlayColourProvider(OverlayColourScheme.Purple);
+
+        protected override bool UseOnlineAPI => true;
+
+        [SetUp]
+        public void Setup() => Schedule(() =>
+        {
+            Child = new UserSearchDisplay();
+        });
+    }
+}

osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs

@@ -32,8 +32,6 @@ public override void SetUpSteps()
 
             AddStep("set pick state", () => MultiplayerClient.RankedPlayChangeStage(RankedPlayStage.CardPlay, state => state.ActiveUserId = 2).WaitSafely());
 
-            AddWaitStep("wait some", 5);
-
             AddStep("reveal cards", () =>
             {
                 for (int i = 0; i < 5; i++)
@@ -46,6 +44,15 @@ public override void SetUpSteps()
                     }).WaitSafely();
                 }
             });
+
+            AddWaitStep("wait", 15);
+
+            AddStep("play beatmap", () => MultiplayerClient.PlayUserCard(2, hand => hand[0]).WaitSafely());
+            AddStep("reveal card", () => MultiplayerClient.RankedPlayRevealUserCard(2, hand => hand[0], new MultiplayerPlaylistItem
+            {
+                ID = 0,
+                BeatmapID = requestHandler.Beatmaps[0].OnlineID
+            }).WaitSafely());
         }
     }
 }

osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs

@@ -1,12 +1,17 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System.Linq;
 using osu.Framework.Extensions;
+using osu.Framework.Testing;
+using osu.Game.Graphics.UserInterface;
 using osu.Game.Online.API;
 using osu.Game.Online.Multiplayer;
 using osu.Game.Online.Multiplayer.MatchTypes.RankedPlay;
 using osu.Game.Online.Rooms;
 using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay;
+using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Hand;
+using osuTK.Input;
 
 namespace osu.Game.Tests.Visual.RankedPlay
 {
@@ -46,6 +51,30 @@ public override void SetUpSteps()
                     }).WaitSafely();
                 }
             });
+
+            for (int i = 0; i < 3; i++)
+            {
+                int i2 = i;
+                AddStep($"click card {i2}", () =>
+                {
+                    InputManager.MoveMouseTo(this.ChildrenOfType<PlayerHandOfCards.PlayerHandCard>().ElementAt(i2));
+                    InputManager.Click(MouseButton.Left);
+                });
+            }
+
+            AddWaitStep("wait", 3);
+
+            AddStep("click play button", () =>
+            {
+                var button = screen
+                             .ChildrenOfType<PlayerHandOfCards.PlayerHandCard>()
+                             .First(it => it.Selected)
+                             .ChildrenOfType<ShearedButton>()
+                             .First();
+
+                InputManager.MoveMouseTo(button);
+                InputManager.Click(MouseButton.Left);
+            });
         }
     }
 }

osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayBackground.cs

@@ -17,7 +17,6 @@ public partial class TestSceneRankedPlayBackground : OsuTestScene
 
         private readonly Bindable<Colour4> gradientOuter = new Bindable<Colour4>(Color4Extensions.FromHex("AC6D97"));
         private readonly Bindable<Colour4> gradientInner = new Bindable<Colour4>(Color4Extensions.FromHex("544483"));
-        private readonly Bindable<Colour4> dots = new Bindable<Colour4>(Color4Extensions.FromHex("D56CF6"));
 
         public TestSceneRankedPlayBackground()
         {
@@ -40,11 +39,6 @@ public TestSceneRankedPlayBackground()
                             Scale = new Vector2(0.4f),
                             Current = gradientInner,
                         },
-                        new BasicColourPicker
-                        {
-                            Scale = new Vector2(0.4f),
-                            Current = dots,
-                        }
                     ]
                 }
             ];
@@ -54,9 +48,8 @@ protected override void LoadComplete()
         {
             base.LoadComplete();
 
-            gradientOuter.BindValueChanged(e => background.GradientOutside = e.NewValue, true);
-            gradientInner.BindValueChanged(e => background.GradientInside = e.NewValue, true);
-            dots.BindValueChanged(e => background.DotsColour = e.NewValue, true);
+            gradientOuter.BindValueChanged(e => background.GradientBottom = e.NewValue, true);
+            gradientInner.BindValueChanged(e => background.GradientTop = e.NewValue, true);
         }
     }
 }

osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayCornerPiece.cs

@@ -6,6 +6,7 @@
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Testing;
+using osu.Game.Online.API.Requests.Responses;
 using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay;
 using osu.Game.Screens.OnlinePlay.Matchmaking.RankedPlay.Components;
 using osu.Game.Tests.Visual.Multiplayer;
@@ -24,18 +25,18 @@ public override void SetUpSteps()
             {
                 Children =
                 [
-                    new RankedPlayCornerPiece(RankedPlayColourScheme.Blue, Anchor.BottomLeft)
+                    new RankedPlayCornerPiece(RankedPlayColourScheme.BLUE, Anchor.BottomLeft)
                     {
                         State = { BindTarget = visibility },
-                        Child = new RankedPlayUserDisplay(2, Anchor.BottomLeft, RankedPlayColourScheme.Blue)
+                        Child = new RankedPlayUserDisplay(new APIUser { Id = 2, Username = "peppy" }, Anchor.BottomLeft, RankedPlayColourScheme.BLUE)
                         {
                             RelativeSizeAxes = Axes.Both,
                         }
                     },
-                    new RankedPlayCornerPiece(RankedPlayColourScheme.Red, Anchor.TopRight)
+                    new RankedPlayCornerPiece(RankedPlayColourScheme.RED, Anchor.TopRight)
                     {
                         State = { BindTarget = visibility },
-                        Child = new RankedPlayUserDisplay(2, Anchor.TopRight, RankedPlayColourScheme.Red)
+                        Child = new RankedPlayUserDisplay(new APIUser { Id = 2, Username = "peppy" }, Anchor.TopRight, RankedPlayColourScheme.RED)
                         {
                             RelativeSizeAxes = Axes.Both,
                         }