forked from ppy/osu
-
Notifications
You must be signed in to change notification settings - Fork 0
a #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
a #177
Changes from 22 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
b08a86f
Remove left over DI usage
peppy 9a56aed
Add current stage overlay to ranked play (#37202)
LiquidPL dfeb9d8
Remove unused lookup component
peppy db92681
Ignore one more false positive rider issue
peppy 809298d
Turn tests green, for a short while, maybe (#37218)
bdach 0f40d61
Fix skin editor origin dropdown options applying origin in wrong coor…
bdach ea0c04a
Ranked Play: fix cards not going all the way off-screen (#37222)
minetoblend e80e5f3
Ranked play general UI/UX fixes (#37220)
peppy a3a530c
Add method for silently dismissing progress notifications without com…
peppy c570db6
Add ability to search for users (#37225)
peppy 84cce2f
Improve efficiency of tag population (#37228)
peppy ed84dd4
Tidy up track switching handling (#37230)
peppy 97ddc8e
Fix footer buttons still being able to fire their action when tempora…
bdach 2058297
Localise tabs on `DashboardOverlay` (#37236)
diquoks 8c6818e
Add models for improvements to matchmaking lobby (#37226)
smoogipoo ca44d82
Do not send replay frames to spectator server if initial begin play i…
bdach b838564
Make `RankedPlayColourScheme` properly static (#37244)
peppy 93b7c33
Add matchmaking profile badge (#37241)
smoogipoo 9c43739
Improvements to discard screen UX (#37245)
peppy 4b8fa89
Tidy up `ResultsScreen` (#37242)
peppy 3e62330
Update editor icons (#37201)
LiquidPL 6231e06
Fix lack of encode-decode stability when writing out mania beatmaps w…
bdach e36f9b2
Add more ranked play SFX (#37258)
nekodex bcc36b4
Fix missing null check
smoogipoo 0e9664b
Fix multiple issues with ranked play card audio previews (#37262)
peppy ac620ee
Add additional information to the matchmaking queue screen (#37229)
smoogipoo 16a2a96
Add bottom 'ornament' overlay to ranked play (#37288)
LiquidPL ca40749
Ranked Play: Fix chat temporarily appearing during intro (#37294)
smoogipoo daff79b
Ranked Play: Fix stutter when entering queue screen (#37295)
smoogipoo 7c114cd
Update CodeFileSanity (#37293)
smoogipoo 16882c6
Fix `KeyboardStep` precision in Accuracy Challenge (#37299)
diquoks 4fd4544
Replicate osu!web logic in display of matchmaking badge (#37303)
smoogipoo bcf3712
Safeguard rating distribution graph against null InputManager (#37304)
smoogipoo 8050ee3
Add support for grouping by keys in song select for osu!mania (#37285)
bdach e6a74fd
Ranked Play: Work around rating data not always including user (#37310)
smoogipoo 96513ce
Add note on AI usage in contributions
peppy c2ed2f7
Update framework (#37315)
peppy 9ac1ad2
Reduce log spam from spectator client when playing offline (#37316)
bdach 964d3fb
Avoid moving auth files during storage migration
smoogipoo cb843b1
Limit maximum password length for multiplayer lobbies to conformant v…
peppy 9bea319
Fix failing test
smoogipoo b36f8f9
Avoid recomputing full path vertices in `SliderPath` when possible (#…
EVAST9919 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
osu.Game.Rulesets.Mania.Tests/ManiaLegacyBeatmapEncoderTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using NUnit.Framework; | ||
| using osu.Framework.IO.Stores; | ||
| using static osu.Game.Tests.Beatmaps.Formats.LegacyBeatmapEncoderTest; | ||
|
|
||
| namespace osu.Game.Rulesets.Mania.Tests | ||
| { | ||
| [TestFixture] | ||
| public class ManiaLegacyBeatmapEncoderTest | ||
| { | ||
| private static readonly DllResourceStore beatmaps_resource_store = new DllResourceStore(typeof(ManiaLegacyBeatmapEncoderTest).Assembly); | ||
|
|
||
| [TestCase("1K")] | ||
| [TestCase("2K")] | ||
| [TestCase("3K")] | ||
| [TestCase("4K")] | ||
| [TestCase("5K")] | ||
| [TestCase("6K")] | ||
| [TestCase("7K")] | ||
| [TestCase("8K")] | ||
| [TestCase("9K")] | ||
| [TestCase("10K")] | ||
| // [TestCase("11K")] <- See comment in `ManiaBeatmapConverter` ctor for disable reason. | ||
| [TestCase("12K")] | ||
| // [TestCase("13K")] <- See comment in `ManiaBeatmapConverter` ctor for disable reason. | ||
| [TestCase("14K")] | ||
| // [TestCase("15K")] <- See comment in `ManiaBeatmapConverter` ctor for disable reason. | ||
| [TestCase("16K")] | ||
| // [TestCase("17K")] <- See comment in `ManiaBeatmapConverter` ctor for disable reason. | ||
| [TestCase("18K")] | ||
| [TestCase("7K+1")] | ||
| public void TestEncodeDecodeStability(string name) | ||
| { | ||
| var decoded = DecodeFromLegacy(beatmaps_resource_store.GetStream($"Resources/Testing/Beatmaps/{name}.osu"), beatmaps_resource_store, name); | ||
| var decodedAfterEncode = DecodeFromLegacy(EncodeToLegacy(decoded), beatmaps_resource_store, name); | ||
|
|
||
| Sort(decoded.beatmap); | ||
| Sort(decodedAfterEncode.beatmap); | ||
|
|
||
| CompareBeatmaps(decoded, decodedAfterEncode); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/10K-expected-conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"Mappings":[{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":0.0,"Objects":[{"StartTime":0.0,"EndTime":0.0,"Column":0}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":125.0,"Objects":[{"StartTime":125.0,"EndTime":125.0,"Column":1}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":250.0,"Objects":[{"StartTime":250.0,"EndTime":250.0,"Column":2}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":375.0,"Objects":[{"StartTime":375.0,"EndTime":375.0,"Column":3}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":500.0,"Objects":[{"StartTime":500.0,"EndTime":500.0,"Column":4}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":625.0,"Objects":[{"StartTime":625.0,"EndTime":625.0,"Column":5}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":750.0,"Objects":[{"StartTime":750.0,"EndTime":750.0,"Column":6}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":875.0,"Objects":[{"StartTime":875.0,"EndTime":875.0,"Column":7}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1000.0,"Objects":[{"StartTime":1000.0,"EndTime":1000.0,"Column":8}]},{"RandomW":273326509,"RandomX":511,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1125.0,"Objects":[{"StartTime":1125.0,"EndTime":1125.0,"Column":9}]}]} |
46 changes: 46 additions & 0 deletions
46
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/10K.osu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| osu file format v14 | ||
|
|
||
| [General] | ||
| Mode: 3 | ||
|
|
||
| [Metadata] | ||
| Title:keycount test | ||
| TitleUnicode:keycount test | ||
| Artist:mania | ||
| ArtistUnicode:mania | ||
| Creator:spaceman_atlas | ||
| Version:10K | ||
|
|
||
| [Difficulty] | ||
| HPDrainRate:5 | ||
| CircleSize:10 | ||
| OverallDifficulty:5 | ||
| ApproachRate:5 | ||
| SliderMultiplier:1.4 | ||
| SliderTickRate:1 | ||
|
|
||
| [Events] | ||
| //Background and Video events | ||
| //Break Periods | ||
| //Storyboard Layer 0 (Background) | ||
| //Storyboard Layer 1 (Fail) | ||
| //Storyboard Layer 2 (Pass) | ||
| //Storyboard Layer 3 (Foreground) | ||
| //Storyboard Layer 4 (Overlay) | ||
| //Storyboard Sound Samples | ||
|
|
||
| [TimingPoints] | ||
| 0,500,4,2,0,100,1,0 | ||
|
|
||
|
|
||
| [HitObjects] | ||
| 25,192,0,1,0,0:0:0:0: | ||
| 76,192,125,1,0,0:0:0:0: | ||
| 128,192,250,1,0,0:0:0:0: | ||
| 179,192,375,1,0,0:0:0:0: | ||
| 230,192,500,1,0,0:0:0:0: | ||
| 281,192,625,1,0,0:0:0:0: | ||
| 332,192,750,1,0,0:0:0:0: | ||
| 384,192,875,1,0,0:0:0:0: | ||
| 435,192,1000,1,0,0:0:0:0: | ||
| 486,192,1125,1,0,0:0:0:0: |
1 change: 1 addition & 0 deletions
1
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/11K-expected-conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"Mappings":[{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":0.0,"Objects":[{"StartTime":0.0,"EndTime":0.0,"Column":0}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":125.0,"Objects":[{"StartTime":125.0,"EndTime":125.0,"Column":1}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":250.0,"Objects":[{"StartTime":250.0,"EndTime":250.0,"Column":2}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":375.0,"Objects":[{"StartTime":375.0,"EndTime":375.0,"Column":3}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":500.0,"Objects":[{"StartTime":500.0,"EndTime":500.0,"Column":4}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":625.0,"Objects":[{"StartTime":625.0,"EndTime":625.0,"Column":5}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":750.0,"Objects":[{"StartTime":750.0,"EndTime":750.0,"Column":6}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":875.0,"Objects":[{"StartTime":875.0,"EndTime":875.0,"Column":7}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1000.0,"Objects":[{"StartTime":1000.0,"EndTime":1000.0,"Column":8}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1125.0,"Objects":[{"StartTime":1125.0,"EndTime":1125.0,"Column":9}]},{"RandomW":273326509,"RandomX":531,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1250.0,"Objects":[{"StartTime":1250.0,"EndTime":1250.0,"Column":10}]}]} |
47 changes: 47 additions & 0 deletions
47
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/11K.osu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| osu file format v14 | ||
|
|
||
| [General] | ||
| Mode: 3 | ||
|
|
||
| [Metadata] | ||
| Title:keycount test | ||
| TitleUnicode:keycount test | ||
| Artist:mania | ||
| ArtistUnicode:mania | ||
| Creator:spaceman_atlas | ||
| Version:11K | ||
|
|
||
| [Difficulty] | ||
| HPDrainRate:5 | ||
| CircleSize:11 | ||
| OverallDifficulty:5 | ||
| ApproachRate:5 | ||
| SliderMultiplier:1.4 | ||
| SliderTickRate:1 | ||
|
|
||
| [Events] | ||
| //Background and Video events | ||
| //Break Periods | ||
| //Storyboard Layer 0 (Background) | ||
| //Storyboard Layer 1 (Fail) | ||
| //Storyboard Layer 2 (Pass) | ||
| //Storyboard Layer 3 (Foreground) | ||
| //Storyboard Layer 4 (Overlay) | ||
| //Storyboard Sound Samples | ||
|
|
||
| [TimingPoints] | ||
| 0,500,4,2,0,100,1,0 | ||
|
|
||
|
|
||
| [HitObjects] | ||
| 23,192,0,1,0,0:0:0:0: | ||
| 69,192,125,1,0,0:0:0:0: | ||
| 116,192,250,1,0,0:0:0:0: | ||
| 162,192,375,1,0,0:0:0:0: | ||
| 209,192,500,1,0,0:0:0:0: | ||
| 256,192,625,1,0,0:0:0:0: | ||
| 302,192,750,1,0,0:0:0:0: | ||
| 349,192,875,1,0,0:0:0:0: | ||
| 395,192,1000,1,0,0:0:0:0: | ||
| 442,192,1125,1,0,0:0:0:0: | ||
| 488,192,1250,1,0,0:0:0:0: |
1 change: 1 addition & 0 deletions
1
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/12K-expected-conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"Mappings":[{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":0.0,"Objects":[{"StartTime":0.0,"EndTime":0.0,"Column":0}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":125.0,"Objects":[{"StartTime":125.0,"EndTime":125.0,"Column":1}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":250.0,"Objects":[{"StartTime":250.0,"EndTime":250.0,"Column":2}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":375.0,"Objects":[{"StartTime":375.0,"EndTime":375.0,"Column":3}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":500.0,"Objects":[{"StartTime":500.0,"EndTime":500.0,"Column":4}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":625.0,"Objects":[{"StartTime":625.0,"EndTime":625.0,"Column":5}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":750.0,"Objects":[{"StartTime":750.0,"EndTime":750.0,"Column":6}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":875.0,"Objects":[{"StartTime":875.0,"EndTime":875.0,"Column":7}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1000.0,"Objects":[{"StartTime":1000.0,"EndTime":1000.0,"Column":8}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1125.0,"Objects":[{"StartTime":1125.0,"EndTime":1125.0,"Column":9}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1250.0,"Objects":[{"StartTime":1250.0,"EndTime":1250.0,"Column":10}]},{"RandomW":273326509,"RandomX":551,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1375.0,"Objects":[{"StartTime":1375.0,"EndTime":1375.0,"Column":11}]}]} |
48 changes: 48 additions & 0 deletions
48
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/12K.osu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| osu file format v14 | ||
|
|
||
| [General] | ||
| Mode: 3 | ||
|
|
||
| [Metadata] | ||
| Title:keycount test | ||
| TitleUnicode:keycount test | ||
| Artist:mania | ||
| ArtistUnicode:mania | ||
| Creator:spaceman_atlas | ||
| Version:12K | ||
|
|
||
| [Difficulty] | ||
| HPDrainRate:5 | ||
| CircleSize:12 | ||
| OverallDifficulty:5 | ||
| ApproachRate:5 | ||
| SliderMultiplier:1.4 | ||
| SliderTickRate:1 | ||
|
|
||
| [Events] | ||
| //Background and Video events | ||
| //Break Periods | ||
| //Storyboard Layer 0 (Background) | ||
| //Storyboard Layer 1 (Fail) | ||
| //Storyboard Layer 2 (Pass) | ||
| //Storyboard Layer 3 (Foreground) | ||
| //Storyboard Layer 4 (Overlay) | ||
| //Storyboard Sound Samples | ||
|
|
||
| [TimingPoints] | ||
| 0,500,4,2,0,100,1,0 | ||
|
|
||
|
|
||
| [HitObjects] | ||
| 21,192,0,1,0,0:0:0:0: | ||
| 64,192,125,1,0,0:0:0:0: | ||
| 106,192,250,1,0,0:0:0:0: | ||
| 149,192,375,1,0,0:0:0:0: | ||
| 192,192,500,1,0,0:0:0:0: | ||
| 234,192,625,1,0,0:0:0:0: | ||
| 277,192,750,1,0,0:0:0:0: | ||
| 320,192,875,1,0,0:0:0:0: | ||
| 362,192,1000,1,0,0:0:0:0: | ||
| 405,192,1125,1,0,0:0:0:0: | ||
| 448,192,1250,1,0,0:0:0:0: | ||
| 490,192,1375,1,0,0:0:0:0: |
1 change: 1 addition & 0 deletions
1
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/13K-expected-conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"Mappings":[{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":0.0,"Objects":[{"StartTime":0.0,"EndTime":0.0,"Column":0}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":125.0,"Objects":[{"StartTime":125.0,"EndTime":125.0,"Column":1}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":250.0,"Objects":[{"StartTime":250.0,"EndTime":250.0,"Column":2}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":375.0,"Objects":[{"StartTime":375.0,"EndTime":375.0,"Column":3}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":500.0,"Objects":[{"StartTime":500.0,"EndTime":500.0,"Column":4}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":625.0,"Objects":[{"StartTime":625.0,"EndTime":625.0,"Column":5}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":750.0,"Objects":[{"StartTime":750.0,"EndTime":750.0,"Column":6}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":875.0,"Objects":[{"StartTime":875.0,"EndTime":875.0,"Column":7}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1000.0,"Objects":[{"StartTime":1000.0,"EndTime":1000.0,"Column":8}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1125.0,"Objects":[{"StartTime":1125.0,"EndTime":1125.0,"Column":9}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1250.0,"Objects":[{"StartTime":1250.0,"EndTime":1250.0,"Column":10}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1375.0,"Objects":[{"StartTime":1375.0,"EndTime":1375.0,"Column":11}]},{"RandomW":273326509,"RandomX":571,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1500.0,"Objects":[{"StartTime":1500.0,"EndTime":1500.0,"Column":12}]}]} |
49 changes: 49 additions & 0 deletions
49
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/13K.osu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| osu file format v14 | ||
|
|
||
| [General] | ||
| Mode: 3 | ||
|
|
||
| [Metadata] | ||
| Title:keycount test | ||
| TitleUnicode:keycount test | ||
| Artist:mania | ||
| ArtistUnicode:mania | ||
| Creator:spaceman_atlas | ||
| Version:13K | ||
|
|
||
| [Difficulty] | ||
| HPDrainRate:5 | ||
| CircleSize:13 | ||
| OverallDifficulty:5 | ||
| ApproachRate:5 | ||
| SliderMultiplier:1.4 | ||
| SliderTickRate:1 | ||
|
|
||
| [Events] | ||
| //Background and Video events | ||
| //Break Periods | ||
| //Storyboard Layer 0 (Background) | ||
| //Storyboard Layer 1 (Fail) | ||
| //Storyboard Layer 2 (Pass) | ||
| //Storyboard Layer 3 (Foreground) | ||
| //Storyboard Layer 4 (Overlay) | ||
| //Storyboard Sound Samples | ||
|
|
||
| [TimingPoints] | ||
| 0,500,4,2,0,100,1,0 | ||
|
|
||
|
|
||
| [HitObjects] | ||
| 19,192,0,1,0,0:0:0:0: | ||
| 59,192,125,1,0,0:0:0:0: | ||
| 98,192,250,1,0,0:0:0:0: | ||
| 137,192,375,1,0,0:0:0:0: | ||
| 177,192,500,1,0,0:0:0:0: | ||
| 216,192,625,1,0,0:0:0:0: | ||
| 256,192,750,1,0,0:0:0:0: | ||
| 295,192,875,1,0,0:0:0:0: | ||
| 334,192,1000,1,0,0:0:0:0: | ||
| 374,192,1125,1,0,0:0:0:0: | ||
| 413,192,1250,1,0,0:0:0:0: | ||
| 452,192,1375,1,0,0:0:0:0: | ||
| 492,192,1500,1,0,0:0:0:0: |
1 change: 1 addition & 0 deletions
1
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/14K-expected-conversion.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"Mappings":[{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":0.0,"Objects":[{"StartTime":0.0,"EndTime":0.0,"Column":0}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":125.0,"Objects":[{"StartTime":125.0,"EndTime":125.0,"Column":1}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":250.0,"Objects":[{"StartTime":250.0,"EndTime":250.0,"Column":2}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":375.0,"Objects":[{"StartTime":375.0,"EndTime":375.0,"Column":3}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":500.0,"Objects":[{"StartTime":500.0,"EndTime":500.0,"Column":4}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":625.0,"Objects":[{"StartTime":625.0,"EndTime":625.0,"Column":5}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":750.0,"Objects":[{"StartTime":750.0,"EndTime":750.0,"Column":6}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":875.0,"Objects":[{"StartTime":875.0,"EndTime":875.0,"Column":7}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1000.0,"Objects":[{"StartTime":1000.0,"EndTime":1000.0,"Column":8}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1125.0,"Objects":[{"StartTime":1125.0,"EndTime":1125.0,"Column":9}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1250.0,"Objects":[{"StartTime":1250.0,"EndTime":1250.0,"Column":10}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1375.0,"Objects":[{"StartTime":1375.0,"EndTime":1375.0,"Column":11}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1500.0,"Objects":[{"StartTime":1500.0,"EndTime":1500.0,"Column":12}]},{"RandomW":273326509,"RandomX":591,"RandomY":842502087,"RandomZ":3579807591,"StartTime":1625.0,"Objects":[{"StartTime":1625.0,"EndTime":1625.0,"Column":13}]}]} |
50 changes: 50 additions & 0 deletions
50
osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/14K.osu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| osu file format v14 | ||
|
|
||
| [General] | ||
| Mode: 3 | ||
|
|
||
| [Metadata] | ||
| Title:keycount test | ||
| TitleUnicode:keycount test | ||
| Artist:mania | ||
| ArtistUnicode:mania | ||
| Creator:spaceman_atlas | ||
| Version:14K | ||
|
|
||
| [Difficulty] | ||
| HPDrainRate:5 | ||
| CircleSize:14 | ||
| OverallDifficulty:5 | ||
| ApproachRate:5 | ||
| SliderMultiplier:1.4 | ||
| SliderTickRate:1 | ||
|
|
||
| [Events] | ||
| //Background and Video events | ||
| //Break Periods | ||
| //Storyboard Layer 0 (Background) | ||
| //Storyboard Layer 1 (Fail) | ||
| //Storyboard Layer 2 (Pass) | ||
| //Storyboard Layer 3 (Foreground) | ||
| //Storyboard Layer 4 (Overlay) | ||
| //Storyboard Sound Samples | ||
|
|
||
| [TimingPoints] | ||
| 0,500,4,2,0,100,1,0 | ||
|
|
||
|
|
||
| [HitObjects] | ||
| 18,192,0,1,0,0:0:0:0: | ||
| 54,192,125,1,0,0:0:0:0: | ||
| 91,192,250,1,0,0:0:0:0: | ||
| 128,192,375,1,0,0:0:0:0: | ||
| 164,192,500,1,0,0:0:0:0: | ||
| 201,192,625,1,0,0:0:0:0: | ||
| 237,192,750,1,0,0:0:0:0: | ||
| 274,192,875,1,0,0:0:0:0: | ||
| 310,192,1000,1,0,0:0:0:0: | ||
| 347,192,1125,1,0,0:0:0:0: | ||
| 384,192,1250,1,0,0:0:0:0: | ||
| 420,192,1375,1,0,0:0:0:0: | ||
| 457,192,1500,1,0,0:0:0:0: | ||
| 493,192,1625,1,0,0:0:0:0: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: winnerspiros/osu
Length of output: 2361
🏁 Script executed:
Repository: winnerspiros/osu
Length of output: 784
🏁 Script executed:
# Read the props file that's imported cat osu.TestProject.propsRepository: winnerspiros/osu
Length of output: 586
🏁 Script executed:
# Read the test file to see complete context cat osu.Game.Rulesets.Mania.Tests/ManiaLegacyBeatmapEncoderTest.csRepository: winnerspiros/osu
Length of output: 1895
🏁 Script executed:
Repository: winnerspiros/osu
Length of output: 2507
🏁 Script executed:
# Read TestResources.cs to see how resources are configured cat osu.Game.Tests/Resources/TestResources.csRepository: winnerspiros/osu
Length of output: 9767
🏁 Script executed:
Repository: winnerspiros/osu
Length of output: 4317
Use the same resource store pattern as the parent test class.
The
DllResourceStoreis initialized from the Mania test assembly, but resource embedding is not explicitly configured in the project file. The parent classLegacyBeatmapEncoderTestusesTestResources.GetStore()to load from the centrally managedosu.Game.Testsassembly, which properly handles resource embedding. Either:<EmbeddedResource>items in the.csprojforResources/Testing/Beatmaps/*.osuTestResources.GetStore()instead🤖 Prompt for AI Agents