Skip to content

Fix Android installation failure - #179

Merged
winnerspiros merged 6 commits into
masterfrom
fix/android-installation-fail-3689318753651662213
Apr 11, 2026
Merged

Fix Android installation failure#179
winnerspiros merged 6 commits into
masterfrom
fix/android-installation-fail-3689318753651662213

Fix code quality and formatting errors in Daily Challenge tests

57f8446
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / InspectCode succeeded Apr 11, 2026 in 8s

18 new alerts

New alerts in code changed by this pull request

  • 18 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 64 in osu.Game.Tests/Visual/DailyChallenge/TestSceneDailyChallengeIntro.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge sequential checks into single conditional access check Warning test

Merge sequential checks

Check warning on line 75 in osu.Game.Tests/Visual/DailyChallenge/TestSceneDailyChallengeIntro.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge sequential checks into single conditional access check Warning test

Merge sequential checks

Check warning on line 114 in osu.Game.Tests/Visual/DailyChallenge/TestSceneDailyChallengeIntro.cs

See this annotation in the file changed.

Code scanning / InspectCode

Merge sequential checks into single conditional access check Warning test

Merge sequential checks

Check warning on line 153 in osu.Game/Screens/Menu/DailyChallengeButton.cs

See this annotation in the file changed.

Code scanning / InspectCode

Separate control transfer statement with blank line Warning

Separate control transfer statement with empty line

Check warning on line 157 in osu.Game/Screens/Menu/DailyChallengeButton.cs

See this annotation in the file changed.

Code scanning / InspectCode

Expression is always false according to nullable reference types' annotations Warning

Expression is always false according to nullable reference types' annotations

Check warning on line 169 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 169 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 353 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 353 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Conditional access qualifier expression is never null according to nullable reference types' annotations Warning

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 358 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Expression is always true according to nullable reference types' annotations Warning

Expression is always true according to nullable reference types' annotations

Check warning on line 538 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Multiple statements on one line Warning

Line break is missing multiple statements on one line

Check warning on line 538 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Use preferred braces style: Enforce braces in 'if' statement Warning

Inconsistent braces style: missing braces

Check warning on line 538 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallenge.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 364 in osu.Game/Screens/OnlinePlay/DailyChallenge/DailyChallengeIntro.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Line break is missing elsewhere Warning

Line break is missing

Check warning on line 49 in osu.Game/Screens/OnlinePlay/DailyChallenge/NewDailyChallengeNotification.cs

See this annotation in the file changed.

Code scanning / InspectCode

Conditional access qualifier expression is never null according to nullable reference types' annotations Warning

Conditional access qualifier expression is never null according to nullable reference types' annotations

Check warning on line 49 in osu.Game/Screens/Play/HUD/SpectatorList.cs

See this annotation in the file changed.

Code scanning / InspectCode

Redundant member initializer Warning

Initializing property by default value is redundant

Check warning on line 90 in osu.Game/Screens/Play/HUD/SpectatorList.cs

See this annotation in the file changed.

Code scanning / InspectCode

Incorrect line breaks: Multiple statements on one line Warning

Line break is missing multiple statements on one line

Check warning on line 157 in osu.Game/Tests/Visual/OnlinePlay/TestRoomRequestsHandler.cs

See this annotation in the file changed.

Code scanning / InspectCode

'if' statement can be rewritten as '??=' assignment Warning

Convert into '??='