Fix Android .NET 10 assembly compression failure (XACAS7023) - #190
Conversation
This commit resolves an issue where 'Microsoft.CSharp.dll' was missing from the trimmer output directory during Android Release builds. Changes: - Transitioned 'Microsoft.CSharp' from a bare Reference to a PackageReference in both 'osu.Android.props' and 'osu.Game.csproj'. This ensures it is correctly classified as a user assembly and preserved in the 'shrunk' directory for all architectures (including android-arm). - Removed the legacy 'AndroidLinkMode' property from 'osu.Android.props' to avoid interference with the modern .NET 10 ILLink trimmer. - Explicitly added 'Microsoft.CSharp' to 'osu.Game' to ensure the runtime binder is available for 'dynamic' usage across all target platforms.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…lve NU1510 CI error This commit resolves an issue where 'Microsoft.CSharp.dll' was missing from the trimmer output directory during Android Release builds by transitioning to a PackageReference in 'osu.Android.props'. It also suppresses the NU1510 warning to ensure compatibility with modern .NET framework targeting in CI.
1 participant
This commit resolves an issue where 'Microsoft.CSharp.dll' was missing from the trimmer output directory during Android Release builds by transitioning to a PackageReference and removing legacy linking properties.
PR created automatically by Jules for task 8252509415480402906 started by @winnerspiros