android: fix .NET 10 APK signing and parsing regressions - #191
Conversation
This commit restores critical build properties and manifest attributes required for stable .NET 10 Android builds, addressing the INSTALL_PARSE_FAILED_NO_CERTIFICATES (null array length) error. - Restored FixRuntimePackAssetTypes target in osu.Android.props to ensure correct classification of native assets. - Restored android:extractNativeLibs="true" in AndroidManifest.xml. - Lowered targetSdkVersion to 35 for better stability during the .NET 10 preview cycle. - Hardened release.yml to ensure workload updates and quoted signing parameters, and improved APK discovery logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Restored FixRuntimePackAssetTypes target in osu.Android.props to ensure correct classification of native assets. - Added Microsoft.CSharp rooting and PackageReference in osu.Android.props to prevent trimmer crashes. - Restored android:extractNativeLibs="true" in AndroidManifest.xml for NativeAOT compatibility. - Lowered targetSdkVersion to 35 for better stability during .NET 10 preview. - Hardened release.yml with workload updates and quoted signing parameters. - Fixed redundant blank lines in DrawableSliderRepeat.cs to resolve security bot warning.
This commit restores critical build properties and manifest attributes required for stable .NET 10 Android builds, addressing the INSTALL_PARSE_FAILED_NO_CERTIFICATES (null array length) error. - Restored FixRuntimePackAssetTypes target in osu.Android.props to ensure correct classification of native assets. - Added Microsoft.CSharp rooting and PackageReference in osu.Android.props to prevent trimmer crashes. - Restored android:extractNativeLibs="true" in AndroidManifest.xml. - Increased targetSdkVersion to 36 in AndroidManifest.xml to match the TargetFrameworkVersion and resolve XA1006 warnings. - Hardened release.yml with workload updates and quoted signing parameters. - Fixed redundant blank lines in DrawableSliderRepeat.cs to resolve security warning.
2 participants
This commit restores critical build properties and manifest attributes required for stable .NET 10 Android builds, addressing the
INSTALL_PARSE_FAILED_NO_CERTIFICATES(null array length) error during APK installation.Key fixes:
FixRuntimePackAssetTypestarget inosu.Android.propsto ensure correct classification of native assets, preventing signature corruption.Microsoft.CSharpinosu.Android.propsto prevent trimmer crashes in reflection-heavy code.android:extractNativeLibs="true"inAndroidManifest.xml, which is required for NativeAOT on modern Android.targetSdkVersionto 35 for better stability during the .NET 10 preview cycle, avoiding experimental API 36 packaging behaviors.release.ymlby restoringdotnet workload update, adding quotes to signing parameters, and strictly prioritizing thepublish/directory for artifact discovery.PR created automatically by Jules for task 6592730468580060468 started by @winnerspiros