Fix Android installation failure (INSTALL_PARSE_FAILED_NO_CERTIFICATES) - #193
Conversation
This commit addresses the .NET 10 Android regression causing "Attempt to get length of null array" during APK installation. Changes: - Strengthened the `FixRuntimePackAssetTypes` target in `osu.Android.props` to hook into `ComputeResolvedFilesToPublishList`, ensuring all native assets are correctly categorized as 'native' for the signing phase. - Updated `.github/workflows/release.yml` to use environment variables for signing secrets (`ALIAS`, `KEYPASS`, `STOREPASS`) to prevent shell expansion of special characters in passwords. - Enforced strict APK discovery in the release workflow by prioritizing the `publish/` directory and removing the unsafe fallback to `bin/Release/`, which often contained unsigned or malformed intermediates. - Verified that `android:extractNativeLibs="true"` and `targetSdkVersion="35"` are consistently applied across all `AndroidManifest.xml` files for .NET 10 stability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Changed double quotes to single quotes in `if` expressions to resolve YAML parsing errors.
1 participant
This PR addresses the .NET 10 Android regression causing "Attempt to get length of null array" during APK installation.
Key changes:
FixRuntimePackAssetTypestarget inosu.Android.propsto hook intoComputeResolvedFilesToPublishList, ensuring all native assets are correctly categorized as 'native' for the signing phase..github/workflows/release.ymlto use environment variables for signing secrets (ALIAS,KEYPASS,STOREPASS) to prevent shell expansion of special characters in passwords.publish/directory and removing the unsafe fallback tobin/Release/, which often contained unsigned or malformed intermediates.android:extractNativeLibs="true"andtargetSdkVersion="35"are consistently applied across allAndroidManifest.xmlfiles for .NET 10 stability.PR created automatically by Jules for task 10988878312507233183 started by @winnerspiros