Fix APK signing, merge upstream ppy/osu, optimize Android performance & input - #199
Merged
Merged
Conversation
Annoying my rider.
Displays the stage name and details like currently picking player and damage multiplayer where applicable. Currently only shown on the discard and pick stages. # Move user retrieval to `RankedPlayScreen` This is done because I need the relevant `APIUser` instances in order to pass them to the overlay component. `RankedPlayScreen` seems like the appropriate place to manage the overlays since it manages the stage subscreens, hence the need to access the `APIUser`s in here. # Add current stage overlay to ranked play The actual change of this PR. Very much a dev design. https://github.com/user-attachments/assets/2388e934-2fc7-4e15-9947-9f98412765d2 --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
## [Rewrite `BackgroundMusicManager` to not run into framework breakage](ppy@622216d) The attempted proper fix to this was ppy/osu-framework#6727. Unfortunately when presented with [the framework bump](ppy#37217) with that change, CI says "you're stupid" and fails on some disposal idiocy that of course is undebuggable and irreproducible: The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.) ---> System.NullReferenceException: Object reference not set to an instance of an object. at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean disposing) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) --- End of inner exception stack trace --- at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren() at osu.Framework.Threading.AudioThread.OnExit() at osu.Framework.Threading.GameThread.setExitState(GameThreadState exitState) at osu.Framework.Threading.GameThread.RunSingleFrame() at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0() at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) --- End of stack trace from previous location --- at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119) I no longer have the energy for any of this shit. @nekodex would appreciate if you could check that I actually haven't broken anything with the bgm here. Seems okay to me in test scenes at least. ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking tests](ppy@7bd3ca4) None of the failures are reproducible locally, of course. I'm tired of this. If anyone else wants to subject themselves to actually investigating any of these, by all means, godspeed and good luck.
…dinate space (ppy#37219) Closes ppy#37185. The checkboxes in the context menu's ternary states were supposed to always show the origin "in local space", even if anchor is set to "closest". The issue here was reusing a method that only really made sense with closest anchor active for explicit application of "local-space" origin. To recap: - Below I will use concepts of "local-space origin" and "screen-space origin". To understand the difference, let's use an example: Say there's a drawable with 180 degree rotation. Suppose it has the "local origin" of `TopCentre`. The "local origin" is just the `Drawable` notion of origin; you'd literally set `d.Origin = Anchor.TopCentre`. The "screen-space origin" of this drawable is `BottomCentre`, because due to the rotation, that's how the component will visually behave when its position is altered. The same sort of distinction applies forth to things like flips / negative scale and such. - When you have closest anchor selected, you can only choose the anchor to snap to. The drawable will snap to that anchor, and choose an origin closest to it *in screen space* such that the "closest" in "closest anchor" works as users would expect it to. In this state, if you open the context menu for origin, all items will be disabled, but the ternary menu items will show the origin state *as translated back to local space*. - When you have an explicit anchor selected, you can choose both the anchor and origin. In that case, the origin picked is always picked in local space. In the end, this is all consistent with how the `Origin` property on `Drawable` works, and also with what is serialised to skin jsons.
`RankedPlaySubScreen.CenterColumn` had a padding which moved the card hand up slightly, causing it to not fully dissapear when contracting. The padding doesn't serve any purpose anymore (remnant of the very early versions of the screens), so I just removed it. I checked against `DiscardScreen`, `PickScreen`, `OpponentPickScreen` & `EndedScreen` to make sure this doesn't cause any layout breakage. Also removed the `ButtonsContainer` since it isn't being used anywhere anymore. https://github.com/user-attachments/assets/2fd32407-fbf7-45a3-b92a-0730a0f8a3fd
…pletion (ppy#37227) This was used in one place, but I foresee this being a more common scenario. This also fixes an edge case where the dismiss process would fail if completion happened on an async thread before the `NotificationOverlay`'s scheduler could handle the initial ingress.
This was a private request for roundtable event usage. It’s also a common feature request, so I decided to spend a bit of time getting this working well-enough. https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5 --- ### Delay loading spinner / loading layer initial load briefly to avoid flickering There's cases in this overlay where loading takes a few milliseconds. The loading spinner gets annoying. This also happens elsewhere, so this could be considered a global fix. Separate PR? probably... ### Ingest loading state of dashboard child content to show more correct loading layer Each display had their own loading layer implementation, but this is already too deep (inside the scroll content) and doesn't display great when for instance, results don't take up the full screen height. --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
- No longer holds realm write transaction open while performing sqlite lookups. - No longer attempts a write transaction when it will be a noop. I'll admit that this is maybe working around the actual realm write part being slow, but as I can't profile the issue locally, the sluggishness may actually be in sqlite for those users affected (since it's only been reported for tag population and not difficulty calculation?). Regardless, this should fix the issue this iteration. I also adjusted the user messaging to let them know why tag population is happening, since we've had some questions as to why it's running in the first place (it only happens once a month, so that's understandable). - [x] Depends on ppy#37227. - Closes ppy#34699. - Closes ppy#37210. Note that ppy#36128 also exists and has valid improvements which can be addressed separately. This is intended to be something we can act on immediately. --------- Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
This doesn't fix ppy#37136, but it does fix the fact that I left some weird code around in ppy@aab01b0 that wasn't required (the re-equality check and disposal). Just cleaning that up here. I doubt it will fix the issue. But also, I can't see how the issue can occur yet.
…rily hidden by overlay content (ppy#37231) In human words: I read [this forum thread](https://osu.ppy.sh/community/forums/topics/2195138?n=1) today and was horrified to see the user there opening the F3 options menu in song select *when the F1 mod overlay was pulled up*, which is (a) not intended UX, (b) looks terrible, and (c) just wrecks the game behaviourally wholesale from start to end. So with this change you don't get to open options via F3 while inside mod overlay at all. The `Action` shadowing is pretty ugly but I don't have better ideas. Initially I tried to mess with `Enabled` (as I did once previously, see ppy@36628e2), but it's much more complicated in this case because the enabled state needs to be restored when the buttons reappear, or it could change independently while the buttons are temporarily hidden, etc. So I'd rather just not deal with all that and invent a parallel scheme.
1. Gives `MatchmakingJoinLobby` parameters. 2. Adds additional data to lobby status update models. A further PR will build upon (2) to add more data to the queue screen.
…nvocation failed (ppy#37159) RFC Until now, if the initial `BeginPlaySession()` call failed, the client would continue operating as if it didn't - it would still continue to send frames and call `EndPlaySession()` at the end of a session. Server-side, two things generally can happen after this: - The sent frames and the `EndPlaySession()` call are [completely](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L122-L125) [ignored](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L153-L157) as no-ops, or - A hub filter (like `ClientVersionChecker`) that failed the initial `BeginPlaySession()` call continues to fail the calls to `SendFrameData()` and `EndPlaySession()`, all the while creating a storm in logs, because it needs to throw `HubException`s to communicate to users that they need to update their game, and the exceptions can't be silenced from logs because they look like every other failure. To that end, this has two goals: reduce useless network traffic, and reduce noise in spectator server logs after the client version checks were recently reactivated. Probably needs tests, but unsure if everyone's going to be on board with this to begin with to be quite frank, so I'm leaving tests for when I'm told this needs tests.
Using the same styling as osu!web + daily challenge. <img width="1920" height="1034" alt="Screenshot_20260409-164600" src="https://github.com/user-attachments/assets/97e2270e-af9f-478d-b2d6-c9fb8be16720" /> --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
Just an initial grab bag to keep these PRs small. ### Avoid showing countdown update when at discard screen This is needless. We already have the `DiscardFinish` stage which has a short countdown. Playing this change to the user creates unnecessary confusion. ### Allow stage caption text to be changed at any point Also remove custom colour support. We'll handle this internally in a better way in the future. ### Better explain why we're waiting after discarding our own cards
Just the bare minimum code quality so I can start working on these classes.. Please push back if this doesn't seem better than what was already there. This is mostly autopilot fixing for me based on how I've been writing code for osu! to date. There are changes to the load process but nothing which should cause issues, I hope.
Brings in new fresh icons for the toolbox (select, hitcircle, slider, spinner, grid) and toggles (new combo, whistle, finish, clap, grid/distance snap). Depends on ppy/osu-resources#416. | Before | After | |--------|--------| | <img width="300" height="897" alt="image" src="https://github.com/user-attachments/assets/279ea162-c3e2-4312-a0a2-39ad08df16f9" /> | <img width="304" height="889" alt="image" src="https://github.com/user-attachments/assets/aab2a143-0e6b-45c1-bf84-8998c12bd960" /> |
…ith some key counts (ppy#37256) Closes ppy#37232. The actual fix is ppy@e959b20; everything else is window dressing / test harness to ensure I don't try and do a wrong change like ppy#37251 did. I recommend reviewing commit-by-commit. See [this desmos](https://www.desmos.com/calculator/a5yjpacvxa) for visual explanation of change, I think it does a better job at explaining this than any words I could type here. Of note: - In the end this did only affect 14K but that should never be assumed when floating point is involved. - Test cases generated here were generated in stable manually. - Except for 11 / 13 / 15 / 17K which are not officially supported and which don't work in lazer due to orthogonal reasons (see comment added in this PR in `ManiaBeatmapConverter`), decoding in lazer was always fine. - My worry was that the old encoding method before this PR could potentially cause stable to move a note from one column to another but thankfully that is not the case. The old method of encoding columns as X positions does not cause issues wherein lazer reads them back differently than stable after encode. I checked this by checking out `master`, re-encoding all of the test stair-pattern nK beatmaps added in this PR on `master`, exporting that as compatibility, re-importing to stable, and cross-checking that the decoded beatmap is visually the same on lazer and on stable. This is important to check because if this wasn't the case, we'd potentially have cases of actual online beatmaps (remember that we have BSS now) wherein a beatmap plays differently on stable than on lazer due to notes moving between columns, and would need to screen for this being the case and potentially apply corrective / reconciliatory action.
- Stage changes (with ducking): https://github.com/user-attachments/assets/1ed1cf5a-759b-487a-9028-314accc15a6a - Messages (with debouncing): https://github.com/user-attachments/assets/c8c38d18-4fcc-4654-887b-be3de3e84949 Message sample might be a bit too clicky, but consider this a first pass. --- - [x] depends on ppy/osu-resources#417 --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
The main goal here is to: - Make keyboard selection play previews just like hovering does with mouse. - Make sure cards don't play previews when they are in animation. - Drive by fix to fix toggling discard not working via keyboard. (I really want to rewrite all these classes, the structure is not great) --------- Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
- [x] Depends on ppy#37226 - [x] Depends on ppy/osu-server-spectator#464 This adds two new components to the queue screen: - A listing of the most recently completed matches (global). - A rank distribution graph. It looks something like this (fake data / test scene): <img width="1669" height="1005" alt="image" src="https://github.com/user-attachments/assets/caa57119-4267-4c6e-9898-2f414de865bf" /> It's completely dev-design(TM), but I used Lichess as inspiration for the graph, and the original design document as inspiration for the panels. As for the history, because these are _completed_ matches one of the player life points will always be 0, but I've designed it so as to possibly support showing ongoing matches too in the future. It's only supported for ranked play right now, though there is no reason we couldn't track quick play rooms too (it's just... I'm not sure how to design the panels for quick play). --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
This commit adds an always present overlay to all ranked play screens, meant to indicate to the user that a ranked play session in currently in progress. This has been largely inspired by the pre-shader argon healthbar code. It shouldn't have the same performance concerns, however, since the paths are only calculated once when loading the drawable (and eventually when it is resized, if ever). `RankedPlayScreen`: <img width="1838" height="1353" alt="image" src="https://github.com/user-attachments/assets/c621d759-a88f-49f0-b0df-3a6da90eca65" /> Gameplay: <img width="1838" height="1353" alt="image" src="https://github.com/user-attachments/assets/ee848d06-3878-4cbb-bd4b-de2c4bcfa688" /> Currently the drawable overlaps with some components, but it will be resolved in later pull requests. --------- Co-authored-by: Dean Herbert <pe@ppy.sh>
I was kind of lazy with the disappear/appear stuff. Made it properly set the required state at the correct time now. Made a second fix to change it into a visibility container, so that bindable states are deduped. On `master` it would re-appear from the bottom with every stage change.
The panels look up the online APIUser models. Maybe I could do this by doing the lookups async inside `RankedPlayMatchPanel`, but this will probably do for now?
Has been failing on master for some time now because .NET 6 is not supported anymore.
winnerspiros
approved these changes
Apr 17, 2026
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the repo to a newer upstream ppy/osu baseline while addressing Android Release APK install failures (missing certificates) and reducing APK size via arm64-only packaging and native library compression. It also brings in a large set of upstream gameplay/UI updates (ranked play, song select grouping by ruleset variant, dashboard user search/profile matchmaking stats) and test adjustments.
Changes:
- Fix Android Release APK signing/install issues by narrowing
FixRuntimePackAssetTypesto.soonly and adding anapksignerverify+fallback signing step in the release workflow. - Update framework/resources package versions and merge upstream features/changes (ranked play UI, matchmaking, spectator, editor, and song select improvements).
- Optimise Android APK size by switching to arm64-only and allowing native library compression (
extractNativeLibsremoval).
Reviewed changes
Copilot reviewed 195 out of 197 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| osu.iOS.props | Bumps iOS framework package version. |
| osu.Game/osu.Game.csproj | Updates framework/resources package versions. |
| osu.Game/Tests/Visual/TestUserLookupCache.cs | Adds cover URL to test user. |
| osu.Game/Tests/Visual/Spectator/TestSpectatorClient.cs | Updates spectator begin-play override to return success. |
| osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs | Updates matchmaking client test stubs for new request/response API. |
| osu.Game/Tests/Visual/EditorSavingTestScene.cs | Ensures ruleset set-up step before beatmap steps. |
| osu.Game/Screens/Select/PanelBeatmapStandalone.cs | Displays ruleset variant name rather than mania keycount. |
| osu.Game/Screens/Select/PanelBeatmap.cs | Displays ruleset variant name and renames UI elements accordingly. |
| osu.Game/Screens/Select/Filter/GroupMode.cs | Adds Variant grouping mode. |
| osu.Game/Screens/Select/BeatmapCarouselFilterGrouping.cs | Implements grouping by ruleset variant. |
| osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerMatchSettingsOverlay.cs | Tightens invite secret length limit (rich presence constraints). |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/ResultsScreen.ScoreBar.cs | Tweaks score bar visuals. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/ResultsScreen.PanelScaffold.cs | Updates colour scheme constant names. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/RankedPlaySubScreen.cs | Refactors stage overlay/stage caption API. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/RankedPlayMatchInfo.cs | Adds IsOpponentTurn convenience property. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/RankedPlayColourScheme.cs | Converts colour schemes to static readonly instances. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/RankedPlayBackgroundScreen.cs | Refactors background ownership and colour handling. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/PickScreen.cs | Refactors stage caption + warning sample logic. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/OpponentPickScreen.cs | Refactors stage caption + colour scheme. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/VsSequence.cs | Extracts delay constants and exposes intro length. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/IntroScreen.cs | Adjusts stage heading visibility/override. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/PlayerHandOfCards.cs | Avoids play-trigger when no play action exists. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/HandOfCards.cs | Moves layout invalidation to LayoutValue. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/HandOfCards.HandCard.cs | Toggles card audio preview based on hover state. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/DiscardScreen.cs | Refactors stage caption updates + preview disabling during animation. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Components/RankedPlayUserDisplay.cs | Passes APIUser directly; adjusts room update/unsubscribe safety. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Components/RankedPlayStageDisplay.cs | Adds stage-aware countdown handling + refactors caption/heading wiring. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Components/RankedPlayChatDisplay.cs | Converts to VisibilityContainer and adds message received sample. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Components/BackgroundMusicManager.cs | Refactors to state-driven playback control. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs | Adds PlayAudioPreview passthrough. |
| osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.SongPreview.cs | Refactors preview start logic to bindables, decoupling from hover events. |
| osu.Game/Screens/Footer/ScreenFooterButton.cs | Adds button on-screen state and prevents triggering while hidden. |
| osu.Game/Screens/Footer/ScreenFooter.cs | Uses new footer button state when hiding/showing buttons. |
| osu.Game/Screens/Edit/Components/TernaryButtons/NewComboTernaryButton.cs | Updates icon mapping for new-combo. |
| osu.Game/Rulesets/Ruleset.cs | Introduces ruleset variant description + beatmap-to-variant mapping API. |
| osu.Game/Rulesets/Objects/SliderPath.cs | Exposes CalculatedPath for reuse. |
| osu.Game/Rulesets/Mods/ModAccuracyChallenge.cs | Increases slider keyboard precision. |
| osu.Game/Rulesets/ILegacyRuleset.cs | Removes legacy mania keycount default method. |
| osu.Game/Rulesets/Filter/IRulesetFilterCriteria.cs | Extends mod-change API with criteria parameter. |
| osu.Game/Rulesets/Difficulty/RulesetBeatmapAttribute.cs | Adds ruleset-specific beatmap attribute representation type. |
| osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs | Refactors origin application between local/screen space. |
| osu.Game/Overlays/Settings/Sections/General/UpdateSettings.cs | Uses new silent completion method for update check notification. |
| osu.Game/Overlays/Profile/Header/Components/MatchmakingStatsTooltip.cs | Adds tooltip UI for matchmaking stats. |
| osu.Game/Overlays/Profile/Header/Components/MatchmakingStatsDisplay.cs | Adds compact matchmaking stats display + tooltip binding. |
| osu.Game/Overlays/Profile/Header/Components/MainDetails.cs | Adds matchmaking stats to profile header layout. |
| osu.Game/Overlays/Notifications/ProgressNotification.cs | Adds CompleteSilently() helper. |
| osu.Game/Overlays/MusicController.cs | Adjusts track switching sequence and adds update-thread assert. |
| osu.Game/Overlays/DashboardOverlay.cs | Adds loading bindable + new user search tab. |
| osu.Game/Overlays/Dashboard/UserSearch/UserPanelList.cs | Adds user list rendering for dashboard search. |
| osu.Game/Overlays/Dashboard/Friends/UserListToolbar.cs | Adds optional sort support + default params. |
| osu.Game/Overlays/Dashboard/Friends/FriendDisplay.cs | Refactors to expose loading state via bindable. |
| osu.Game/Overlays/Dashboard/DashboardOverlayHeader.cs | Localises dashboard tab names and adds user search tab. |
| osu.Game/Overlays/Dashboard/CurrentlyOnline/CurrentlyOnlineDisplay.cs | Refactors to expose loading state via bindable. |
| osu.Game/Online/Spectator/SpectatorClient.cs | Refactors begin-play to return success and clears state on failure. |
| osu.Game/Online/Spectator/OnlineSpectatorClient.cs | Implements success/failure result for begin-play, logs failures. |
| osu.Game/Online/Multiplayer/OnlineMultiplayerClient.cs | Changes matchmaking lobby join to request/response API. |
| osu.Game/Online/Multiplayer/MultiplayerClient.cs | Updates abstract matchmaking lobby join method signature. |
| osu.Game/Online/Multiplayer/MatchTypes/RankedPlay/RankedPlayUserInfo.cs | Adds RoundsWon field for ranked play info. |
| osu.Game/Online/Matchmaking/Responses/MatchmakingJoinLobbyResponse.cs | Adds response DTO for lobby join. |
| osu.Game/Online/Matchmaking/Requests/MatchmakingJoinLobbyRequest.cs | Adds request DTO for lobby join parameters. |
| osu.Game/Online/Matchmaking/MatchmakingLobbyStatus.cs | Extends lobby status payload (ratings, recent matches). |
| osu.Game/Online/Matchmaking/IMatchmakingServer.cs | Updates server contract to request/response join method. |
| osu.Game/Online/API/Requests/SearchUsersResponse.cs | Adds API response model for user search. |
| osu.Game/Online/API/Requests/SearchUsersRequest.cs | Adds API request for user search. |
| osu.Game/Online/API/Requests/Responses/APIUserMatchmakingStatistics.cs | Adds API model for matchmaking stats. |
| osu.Game/Online/API/Requests/Responses/APIUser.cs | Adds matchmaking stats field to APIUser. |
| osu.Game/Online/API/Requests/Responses/APIMatchmakingPool.cs | Adds API model for matchmaking pool. |
| osu.Game/Localisation/UserInterfaceStrings.cs | Adds localisation strings for dashboard tabs. |
| osu.Game/IO/OsuStorage.cs | Adds AuthNative files to ignore list during migration. |
| osu.Game/Graphics/UserInterface/LoadingSpinner.cs | Adds slight fade-in delay to reduce flicker. |
| osu.Game/Graphics/OsuIcon.cs | Adds/adjusts editor icon mappings. |
| osu.Game/Graphics/Backgrounds/Triangles.cs | Makes spawn ratio configurable via property. |
| osu.Game/Database/BackgroundDataStoreProcessor.cs | Refactors tag backpopulation messaging/progress and silent completion for no-op runs. |
| osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs | Updates mania column mapping to match stable reference. |
| osu.Game/Beatmaps/BeatmapSetNominationStatusRequiredMeta.cs | Renames nomination meta type for clarity. |
| osu.Game/Beatmaps/BeatmapSetNominationStatus.cs | Uses renamed nomination meta type. |
| osu.Game.Tests/Visual/UserInterface/TestSceneUserListToolbar.cs | Updates toolbar test constructor usage. |
| osu.Game.Tests/Visual/UserInterface/TestSceneScreenFooter.cs | Adds test ensuring hidden footer buttons can’t be triggered. |
| osu.Game.Tests/Visual/UserInterface/TestSceneNotificationOverlay.cs | Adds tests for silent progress completion. |
| osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapRecommendations.cs | Marks a test as flaky. |
| osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarouselSetsSplitApart.cs | Marks a test as flaky. |
| osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarouselFiltering.cs | Uses AddUntilStep for eventual consistency. |
| osu.Game.Tests/Visual/Ranking/TestSceneSoloResultsScreen.cs | Marks a test as flaky. |
| osu.Game.Tests/Visual/Ranking/TestSceneResultsScreen.cs | Makes panel retrieval robust via AddUntilStep. |
| osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayUserDisplay.cs | Updates tests for RankedPlayUserDisplay API change. |
| osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayStageOverlay.cs | Adds visual test scene for stage overlay. |
| osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayMatchPanel.cs | Adds visual test scene for match panel (round wins). |
| osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayCornerPiece.cs | Updates tests for colour scheme/constants and APIUser usage. |
| osu.Game.Tests/Visual/RankedPlay/TestSceneRankedPlayBackground.cs | Updates background bindings to new gradient properties. |
| osu.Game.Tests/Visual/RankedPlay/TestScenePickScreen.cs | Adds input steps for selecting/playing cards. |
| osu.Game.Tests/Visual/RankedPlay/TestSceneOpponentPickScreen.cs | Extends scenario steps to play/reveal cards. |
| osu.Game.Tests/Visual/Online/TestSceneUserSearchDisplay.cs | Adds visual test for user search display. |
| osu.Game.Tests/Visual/Online/TestSceneUserProfileMatchmakingStatsDisplay.cs | Adds visual test for matchmaking stats UI. |
| osu.Game.Tests/Visual/Online/TestSceneFriendDisplay.cs | Makes load assertions more robust. |
| osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs | Marks a test as flaky. |
| osu.Game.Tests/Visual/Multiplayer/TestSceneMultiplayer.cs | Makes mod-overlay hidden assertion resilient to multiples. |
| osu.Game.Tests/Visual/Matchmaking/TestSceneRatingDistributionGraph.cs | Adds visual test for rating distribution graph. |
| osu.Game.Tests/Visual/Matchmaking/TestSceneMatchmakingQueueScreen.cs | Updates matchmaking queue test to use lobby status updates. |
| osu.Game.Tests/Visual/Gameplay/TestSceneSliderPath.cs | Uses new CalculatedPath in visuals. |
| osu.Game.Tests/Visual/Gameplay/TestSceneGameplaySamplePlayback.cs | Ignores persistently failing test. |
| osu.Game.Tests/Visual/Gameplay/TestSceneBezierConverter.cs | Uses new CalculatedPath in visuals. |
| osu.Game.Tests/Visual/Editing/TestSceneOpenEditorTimestamp.cs | Makes beatmap retrieval more robust/null-safe. |
| osu.Game.Tests/Visual/Editing/TestSceneLocallyModifyingOnlineBeatmaps.cs | Marks a test as flaky. |
| osu.Game.Tests/Visual/Editing/TestSceneEditorSaving.cs | Marks a test as flaky. |
| osu.Game.Tests/NonVisual/Filtering/FilterQueryParserTest.cs | Updates interface method signature. |
| osu.Game.Tests/NonVisual/Filtering/FilterMatchingTest.cs | Updates interface method signature. |
| osu.Game.Tests/NonVisual/CustomDataDirectoryTest.cs | Updates ignore-file assertions for AuthNative. |
| osu.Game.Tests/Database/BackgroundDataStoreProcessorTests.cs | Marks a test as flaky. |
| osu.Game.Tests/Beatmaps/TestSceneBeatmapDifficultyCache.cs | Marks a test as flaky. |
| osu.Game.Rulesets.Osu/Utils/OsuHitObjectGenerationUtils.Reposition.cs | Uses new CalculatedPath for bounds calculation. |
| osu.Game.Rulesets.Osu/Skinning/SnakingSliderBody.cs | Uses new CalculatedPath for curve generation. |
| osu.Game.Rulesets.Osu/Skinning/Default/TrianglesPiece.cs | Sets spawn ratio via new property. |
| osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuHitObject.cs | Adds suppression comment for Rider inspection. |
| osu.Game.Rulesets.Osu/Edit/SpinnerCompositionTool.cs | Switches to new editor icon mapping. |
| osu.Game.Rulesets.Osu/Edit/SliderCompositionTool.cs | Switches to new editor icon mapping. |
| osu.Game.Rulesets.Osu/Edit/HitCircleCompositionTool.cs | Switches to new editor icon mapping. |
| osu.Game.Rulesets.Osu/Edit/GridFromPointsTool.cs | Switches to new editor icon mapping. |
| osu.Game.Rulesets.Osu/Edit/Blueprints/Sliders/Components/SliderBodyPiece.cs | Uses new CalculatedPath for vertices. |
| osu.Game.Rulesets.Mania/ManiaRuleset.cs | Adds variant description + beatmap-to-variant mapping. |
| osu.Game.Rulesets.Mania/ManiaFilterCriteria.cs | Reapplies filtering when grouping by variant/mods change. |
| osu.Game.Rulesets.Mania/Beatmaps/ManiaBeatmapConverter.cs | Documents behaviour for keycounts above 10. |
| osu.Game.Rulesets.Mania.Tests/osu.Game.Rulesets.Mania.Tests.csproj | Adds reference to shared test project. |
| osu.Game.Rulesets.Mania.Tests/TestSceneTimingBasedNoteColouring.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/TestSceneReplayRewinding.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/TestSceneOutOfOrderHits.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/TestSceneMaximumScore.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/TestSceneHoldNoteInput.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/Mods/TestSceneManiaModNoRelease.cs | Ensures ruleset set to mania in scene. |
| osu.Game.Rulesets.Mania.Tests/ManiaLegacyBeatmapEncoderTest.cs | Adds encode/decode stability tests. |
| osu.Game.Rulesets.Mania.Tests/ManiaBeatmapConversionTest.cs | Expands conversion coverage to local keycount fixtures. |
| osu.Game.Rulesets.Mania.Tests.iOS/osu.Game.Rulesets.Mania.Tests.iOS.csproj | Adds reference to shared test project. |
| osu.Game.Rulesets.Mania.Tests.Android/osu.Game.Rulesets.Mania.Tests.Android.csproj | Adds reference to shared test project. |
| osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/*.osu | Adds mania keycount fixture beatmaps. |
| osu.Game.Rulesets.Mania.Tests/Resources/Testing/Beatmaps/*-expected-conversion.json | Adds expected conversion outputs for fixtures. |
| osu.Game.Rulesets.Catch/Objects/JuiceStreamPath.cs | Uses new CalculatedPath for conversion. |
| osu.Game.Rulesets.Catch/Edit/Blueprints/Components/ScrollingPath.cs | Avoids allocations; uses new CalculatedPath. |
| osu.Desktop/MacOS/MacOSAppLocationChecker.cs | Adds macOS app location warning notification. |
| osu.Android/osu.Android.csproj | Removes arm32 native lib include (arm64-only). |
| osu.Android/OsuGameActivity.cs | Ensures licence header is first line. |
| osu.Android/Native/OboeAudioBridge.cs | Ensures licence header is first line and fixes using order. |
| osu.Android/AndroidManifest.xml | Removes extractNativeLibs=\"false\" to allow .so compression. |
| osu.Android.props | Switches to arm64-only, bumps Android framework package, narrows runtime pack asset fix to .so. |
| README.md | Updates prerequisites and adds Android build/signing docs. |
| CONTRIBUTING.md | Adds AI usage foreword. |
| .github/workflows/release.yml | Arm64-only native build + verify/sign APK fallback step. |
| .config/dotnet-tools.json | Bumps codefilesanity tool version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
122
to
+129
| private bool shouldPlayWarningSample | ||
| => matchInfo.Stage.Value == RankedPlayStage.CardPlay | ||
| && stageDuration > TimeSpan.FromSeconds(warning_time_threshold) | ||
| && stageEndTime - DateTimeOffset.Now < TimeSpan.FromSeconds(warning_time_threshold) | ||
| && !hasPlayedCard; | ||
| { | ||
| get => matchInfo.Stage.Value == RankedPlayStage.CardPlay | ||
| && stageDuration > TimeSpan.FromSeconds(warning_time_threshold) | ||
| && stageEndTime - DateTimeOffset.Now < TimeSpan.FromSeconds(warning_time_threshold) | ||
| && !field; | ||
| set; | ||
| } |
Comment on lines
212
to
219
| public void BeginPlaying(long? scoreToken, GameplayState state, Score score) | ||
| { | ||
| // This schedule is only here to match the one below in `EndPlaying`. | ||
| Schedule(() => | ||
| { | ||
| if (isPlaying) | ||
| { | ||
| Logger.Log($"Cannot invoke {nameof(BeginPlaying)} when already playing. Ignoring."); | ||
| return; | ||
| } | ||
| isPlaying = true; | ||
| throw new InvalidOperationException($"Cannot invoke {nameof(BeginPlaying)} when already playing"); | ||
|
|
Comment on lines
+11
to
+20
| public class SearchUsersResponse | ||
| { | ||
| [JsonProperty("total")] | ||
| public int Total; | ||
|
|
||
| public List<APIUser> Users => data.Users; | ||
|
|
||
| [JsonProperty("user")] | ||
| private UserData data = null!; | ||
|
|
Comment on lines
+8
to
+10
| /// <summary> | ||
| /// Lookup up users with the given <see cref="Query"/>. | ||
| /// </summary> |
Owner
|
@copilot again errors and I a favor for those, we have added stylus , io optimizations , vulkan and oboe. I remember last time I had a successful build. vulkan was glitching and was worse thsn opengl somehow in performance, oboe didnt even run, the check thing worked but did nothing. Keyboard, mouse, stylus couldn't click. Check all the above find whats goin on and optimize. |
…y, DeX auto-optimization Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62a8048b-6fe1-424d-9c00-a3fbddf6ba74 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Fix missing nOboeGetLastErrorMessage in C++ native bridge (P/Invoke crash) - Replace fragile reflection-based BASS handle discovery with direct BassAudioMixer.Handle - Add thread safety (lock) to StartOboeBridge/StopOboeBridge - Dynamic CPU core affinity based on device core count (not hardcoded 0xF8) - Remove duplicate GC latency mode setting (let performance session manage it) - Fix JNI global reference leak in SurfaceCreated - Fix performance mode overriding user's manual refresh rate selection - Remove dead code from input handlers (unused View property, commented-out code) - Add refresh rate dropdown to Android Performance settings - Add DeX immersive fullscreen mode (hide system bars) - Re-query display modes on DeX connect/disconnect - Improve error logging throughout Oboe initialization Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62a8048b-6fe1-424d-9c00-a3fbddf6ba74 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…fety - S Pen now acts as a real tablet: area mapping, rotation, pressure threshold - Display-based initialization from actual screen dimensions (not 2000x1000) - Cached area transform values for hot-path performance - TabletSettings UI shown on Android via CreateSettingsSubsectionFor override - Thread-safe JNI surface ref (Interlocked.Exchange), error string mutex in C++ - Dynamic audio thread affinity matching OsuGameAndroid pattern Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62a8048b-6fe1-424d-9c00-a3fbddf6ba74 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…ix, lazy probe - Cache isStylusEvent() result (was called 2x per event in dispatch methods) - Simplify dispatch flow: early return for stylus/mouse, no redundant checks - Add AggressiveInlining to all input handler hot paths (mouse, stylus, keyboard) - Convert keyboard key map from 80-case switch to static Dictionary (O(1) lookup) - Add deg_to_rad constant for stylus rotation (avoid repeated division) - Request unbuffered dispatch early in OnCreate for minimum input latency - Remove GC.Collect(0) from high-performance session enter (causes micro-stalls) - Gate Vulkan in renderer dropdown behind IsVulkanRecommended (not IsVulkanSupported) On Adreno 7xx GPUs, Vulkan disables 3 critical features → poor performance. Users no longer see Vulkan as an option unless the probe recommends it. - Lazy VulkanProbe: no longer runs at startup, only when user enables the setting (default=false). Saves startup time and native library loading. Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62a8048b-6fe1-424d-9c00-a3fbddf6ba74 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…ed, cutout mode - Set THREAD_PRIORITY_URGENT_DISPLAY (-8) on update/draw/input threads - Always enable SustainedPerformanceMode (not gated behind toggle) - Add android:hardwareAccelerated=true to AndroidManifest - LayoutInDisplayCutoutMode.ShortEdges for full render area - Recycle dummy MotionEvent from early unbuffered dispatch - Fix integer overflow in affinity mask for 32+ core devices - Vulkan only shown when IsVulkanRecommended (not just supported) - Lazy VulkanProbe: no startup cost, only when setting enabled Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/62a8048b-6fe1-424d-9c00-a3fbddf6ba74 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Author
Fixed across commits Build error: Restored Input (keyboard/mouse/stylus): Fixed mouse double-processing (events were passed to both our handler AND the framework's default handler). Simplified dispatch flow with cached S Pen: Rewrote as a true tablet — full area→output coordinate mapping with rotation, display-based initialization, TabletSettings UI now visible on Android (Settings > Input > Tablet). Vulkan: Vulkan option now only shown in renderer dropdown when Oboe: Fixed missing FPS maximization: DeX: Refresh rate dropdown in settings, auto-highest, immersive fullscreen, auto-detect. Refresh rate: Dropdown UI with all available display modes, "Auto (highest)" default. |
Copilot
AI
changed the title
Fix APK signing, merge upstream ppy/osu, optimize APK size
Fix APK signing, merge upstream ppy/osu, optimize Android performance & input
Apr 18, 2026
winnerspiros
approved these changes
Apr 18, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Owner
|
@copilot we already got some errors , can you check? Also you said you disabled vulkan on my s23 ultra. Please don't I want it to show, try to optimize it so it works without issue and hopefully provide better fps than open gl. |
- CS0122: BassAudioMixer is internal to framework, use reflection for Handle - CS0104: Qualify Environment.ProcessorCount as System.Environment - CS8602: Add null check on Window.DecorView before setting PointerIcon - Remove unused refreshRateDropdown field (InspectCode warning) - Re-enable Vulkan in renderer dropdown for all supported GPUs (not just recommended) Users with Adreno 7xx (S23 Ultra) can now see and select Vulkan Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/399426d4-c22f-491c-9cdd-8970c556a3db Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Author
Fixed in 3 CI build errors fixed:
Vulkan re-enabled on S23 Ultra: Changed from About Vulkan performance: I investigated the framework's Veldrid source code ( |
winnerspiros
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APK installation fails with
INSTALL_PARSE_FAILED_NO_CERTIFICATES: Attempt to get length of null arraybecause theFixRuntimePackAssetTypesMSBuild target over-broadly reclassifies signing metadata as native assets, and .NET 10'sdotnet publish -c Releasemay silently skip debug-signing.APK signing fix
FixRuntimePackAssetTypesto only target.sofiles. The previous filter (!= .dll && != .pdb) reclassified config/signing files as native, corrupting the APK signature block:apksignerverification + fallback signing step inrelease.yml. If the SDK produces an unsigned APK, the workflow zipaligns and signs with the debug keystore before upload.Upstream merge (42 commits)
ppy/osumaster: frameworkv2026.416.0, ranked play features, editor improvements, multiplayer fixes.NET 10, AOT, trimming), took upstream game logicAPK size optimization (~457 MB → est. ~150-200 MB)
android-armfromRuntimeIdentifiers. arm32 duplicated ~200 MB of native libs for <1% device coverageextractNativeLibs="false"from AndroidManifest — allows ZIP compression of.sofiles in the APK (~40-50% reduction)Input fixes & S Pen tablet support
Dictionary<Keycode, Key>for O(1) lookupAggressiveInliningon all input handler methods, cachedisStylusEvent()per event,deg_to_radconstantOboe audio pipeline fixes
nOboeGetLastErrorMessageC++ export — was causing P/Invoke crash on error pathBassAudioMixer.Handleproperty accesslockon start/stop in C#,mutexon error string in C++Vulkan / OpenGL
IsVulkanRecommended(not justIsVulkanSupported). On Adreno 7xx GPUs (e.g. S23 Ultra), the native probe disables 3 critical performance features — these devices no longer see Vulkan as an option, preventing users from selecting a broken renderer.FPS maximization
THREAD_PRIORITY_URGENT_DISPLAY(-8) set on update, draw, and input threads via AndroidProcess.SetThreadPrioritySustainedPerformanceModealways enabled — prevents thermal throttling from causing sudden FPS drops (no longer gated behind performance toggle)android:hardwareAccelerated="true"added to AndroidManifestLayoutInDisplayCutoutMode.ShortEdges— renders into notch/cutout area for full display usageGC.Collect(0)from high-performance session entry (was causing micro-stalls)Refresh rate & Samsung DeX
Documentation
apksignersigning instructions, debug keystore generation