Fix BASS DllNotFoundException crash on Android startup

[Copilot]

AndroidNativeLibrary glob in osu.Android.props used backslash path separators, which silently match zero files on Linux CI runners. The build succeeds but the APK ships without libbass.so, causing an immediate System.DllNotFoundException: bass crash in AudioManager..ctor.

Root cause

<!-- Before: backslash glob silently resolves to zero files on Linux -->
<AndroidNativeLibrary Include="$(MSBuildThisFileDirectory)submodules\osu-framework\osu.Framework.Android\arm64-v8a\*.so" />

<!-- After: forward slashes work on both Windows and Linux -->
<AndroidNativeLibrary Include="$(MSBuildThisFileDirectory)submodules/osu-framework/osu.Framework.Android/arm64-v8a/*.so" />

Changes

• osu.Android.props: Switch all submodule paths (ProjectReference + AndroidNativeLibrary) from backslash to forward slash
• osu.Android.props: Add ValidateFrameworkNativeLibraries MSBuild target — fails the build if libbass.so is missing, catching uninitialised submodules or glob regressions
• release.yml: Add post-build APK content verification step that checks for libbass.so, libbass_fx.so, libbassmix.so before upload

No changes required in osu-framework or veldrid.

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[Copilot]

Pull request overview

Fixes an Android startup crash caused by missing native BASS libraries in the shipped APK by making MSBuild globbing cross-platform and adding guardrails in both MSBuild and CI.

Changes:

• Switch osu-framework submodule paths in osu.Android.props from backslashes to forward slashes so AndroidNativeLibrary globs resolve on Linux CI.
• Add an MSBuild validation target intended to fail builds when required framework native libraries are missing.
• Add a CI workflow step to verify required BASS .so files are present inside the produced APK before uploading/releasing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
osu.Android.props	Updates submodule paths to cross-platform separators and adds an MSBuild target to validate presence of framework native libs.
.github/workflows/release.yml	Adds an APK inspection step to fail CI if required BASS native libraries are missing from the APK.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

ValidateFrameworkNativeLibraries currently checks for the presence of libbass.so on disk, not that it was actually picked up by the AndroidNativeLibrary glob. The original regression (backslash glob matching zero items on Linux) would still pass this check because the file exists in the submodule while the item list is empty, and the APK would still ship without the library. Consider validating that @(AndroidNativeLibrary) contains the required libs (or at least is non-empty / contains libbass) instead of using Exists() on the file path.

Suggested change

	<!-- Fail the build early if libbass.so is missing.
	A missing libbass.so means the app will crash on startup with DllNotFoundException.
	This catches silent glob failures (e.g. uninitialised submodule, wrong path). -->
	<Target Name="ValidateFrameworkNativeLibraries" BeforeTargets="Build">
	<Error Condition="!Exists('$(MSBuildThisFileDirectory)submodules/osu-framework/osu.Framework.Android/arm64-v8a/libbass.so')"
	Text="libbass.so not found in submodules/osu-framework/osu.Framework.Android/arm64-v8a/. Ensure the osu-framework submodule is initialised: git submodule update --init --recursive" />
	<!-- Fail the build early if the framework native libraries were not picked up by the
	AndroidNativeLibrary glob. A missing libbass.so means the app will crash on startup
	with DllNotFoundException. This catches silent glob failures (e.g. wrong separators
	on Linux CI, uninitialised submodule, wrong path). -->
	<Target Name="ValidateFrameworkNativeLibraries" BeforeTargets="Build">
	<PropertyGroup>
	<_FrameworkNativeLibraryNames>;@(AndroidNativeLibrary->'%(Filename)%(Extension)', ';');</_FrameworkNativeLibraryNames>
	</PropertyGroup>
	<Error Condition="'$(_FrameworkNativeLibraryNames)' == ';;'"
	Text="No AndroidNativeLibrary items were resolved from submodules/osu-framework/osu.Framework.Android/arm64-v8a/*.so. Ensure the path is correct, the osu-framework submodule is initialised (git submodule update --init --recursive), and forward slashes are used in the glob." />
	<Error Condition="!$([System.String]::Copy('$(_FrameworkNativeLibraryNames)').Contains(';libbass.so;'))"
	Text="libbass.so was not included in @(AndroidNativeLibrary). Ensure the osu-framework submodule is initialised and the native-library glob resolves libbass.so for arm64-v8a." />

[Copilot]

The verification uses grep -q "$LIB" against unzip -l output; grep treats $LIB as a regex and will also match similarly-named entries (e.g. a hypothetical libbass.so.debug would satisfy libbass.so). To make this check robust, consider listing file names only (e.g. unzip -Z1) and using fixed-string / exact matching (e.g. grep -F and matching the full lib/arm64-v8a/$LIB path).