Fix Sentry DSN startup crash; rewrite README for users - #218
Merged
Conversation
…Init in try-catch Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…stream ppy/osu Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
April 20, 2026 16:33
View session
There was a problem hiding this comment.
Pull request overview
Fixes an Android startup crash caused by Sentry initialisation with an invalid/placeholder DSN in deployed builds, and updates the repository README to be end-user focused with technical details folded into expandable sections.
Changes:
- Guard
SentrySdk.Init()with anArgumentExceptioncatch to avoid crashing when DSN is invalid. - Rewrite
README.mdwith clearer user-facing download/install guidance and concise feature explanations. - Move deep technical details (toolchain, framework/Veldrid forks, CI) into
<details>blocks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| osu.Game/Utils/SentryLogger.cs | Prevents startup crash by handling invalid Sentry DSN initialisation gracefully. |
| README.md | Reorients documentation toward end users (download first), while preserving technical details in collapsible sections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APK crashes on startup with
ArgumentException: Invalid DSN: No public key providedbecauseSentrySdk.Initis called with placeholder DSN"https://localhost"on deployed builds whereIsDeployedBuildis true (version major > 0).Changes
SentrySdk.Initintry-catch (ArgumentException)so invalid/placeholder DSNs fail gracefully instead of crashing the app<details>blocks. Covers all fork differences vs upstream (Oboe audio, S Pen/keyboard/mouse input, performance mode, 120Hz+, DeX, Vulkan detection, stability fixes, build toolchain, framework/Veldrid forks, CI/CD).