Skip to content

Fix Sentry DSN startup crash; rewrite README for users - #218

Merged
winnerspiros merged 3 commits into
masterfrom
copilot/fix-crash-on-startup
Apr 20, 2026
Merged

Fix Sentry DSN startup crash; rewrite README for users#218
winnerspiros merged 3 commits into
masterfrom
copilot/fix-crash-on-startup

Conversation

Copilot AI commented Apr 20, 2026

Copy link
Copy Markdown

APK crashes on startup with ArgumentException: Invalid DSN: No public key provided because SentrySdk.Init is called with placeholder DSN "https://localhost" on deployed builds where IsDeployedBuild is true (version major > 0).

Changes

  • SentryLogger.cs: Wrap SentrySdk.Init in try-catch (ArgumentException) so invalid/placeholder DSNs fail gracefully instead of crashing the app
try
{
    sentrySession = SentrySdk.Init(options =>
    {
        options.Dsn = "https://localhost";
        // ...
    });
}
catch (ArgumentException ex)
{
    Logger.Log($"Failed to initialise Sentry SDK: {ex.Message}", LoggingTarget.Runtime, LogLevel.Debug);
    return;
}
  • README.md: Full rewrite targeting end users — plain-language feature descriptions, prominent download section, technical details collapsed into <details> blocks. Covers all fork differences vs upstream (Oboe audio, S Pen/keyboard/mouse input, performance mode, 120Hz+, DeX, Vulkan detection, stability fixes, build toolchain, framework/Veldrid forks, CI/CD).

Copilot AI and others added 3 commits April 20, 2026 16:10
…Init in try-catch

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…stream ppy/osu

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/5842260c-aaa6-4292-9dd0-dffd543601e3

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
@gitar-bot

gitar-bot Bot commented Apr 20, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@winnerspiros
winnerspiros marked this pull request as ready for review April 20, 2026 16:34
Copilot AI review requested due to automatic review settings April 20, 2026 16:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an Android startup crash caused by Sentry initialisation with an invalid/placeholder DSN in deployed builds, and updates the repository README to be end-user focused with technical details folded into expandable sections.

Changes:

  • Guard SentrySdk.Init() with an ArgumentException catch to avoid crashing when DSN is invalid.
  • Rewrite README.md with clearer user-facing download/install guidance and concise feature explanations.
  • Move deep technical details (toolchain, framework/Veldrid forks, CI) into <details> blocks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
osu.Game/Utils/SentryLogger.cs Prevents startup crash by handling invalid Sentry DSN initialisation gracefully.
README.md Reorients documentation toward end users (download first), while preserving technical details in collapsible sections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@winnerspiros
winnerspiros merged commit fd7ced8 into master Apr 20, 2026
5 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants