Fix Android SIGSEGV at pc=0x0, merge upstream, add keystore upload to release workflow

[Copilot]

SIGSEGV null function pointer crash on SDLThread ~5s into Android startup. The Vulkan pipeline receives IntPtr.Zero surface handles when the Android native surface isn't ready, passes them through to vkCreateAndroidSurfaceKHR which dereferences a null ANativeWindow*. Separately, DrawThread.OnInitialize() bypasses AndroidGameHost.DrawFrame()'s IsSurfaceReady guard entirely.

Vulkan surface validation (framework submodule)

• VkSurfaceUtil.cs — validate Surface, JniEnv, and ANativeWindow_fromSurface return before calling into the Vulkan driver
• VeldridDevice.cs — reject IntPtr.Zero for SurfaceHandle/JniEnvHandle on Android with descriptive exception instead of native crash
• AndroidGameHost.DrawFrame() — check SurfaceHandle != IntPtr.Zero in addition to IsSurfaceReady (the flag fires from HandleResume() before the surface handle is actually valid)
• DrawThread.OnInitialize() — wrap BeginFrame/FinishFrame in try-catch; non-fatal on Android when surface isn't ready yet, first regular DrawFrame() handles it

// Before: crashes Vulkan driver with SIGSEGV at pc=0x0
IntPtr aNativeWindow = AndroidRuntime.ANativeWindow_fromSurface(androidSource.JniEnv, androidSource.Surface);
androidSurfaceCi.window = (ANativeWindow*)aNativeWindow; // null

// After: throws managed VeldridException before reaching driver
if (androidSource.Surface == IntPtr.Zero)
    throw new VeldridException("Cannot create Vulkan surface: the Android surface handle is null.");

Upstream merge

Merged 2 commits from ppy/osu master:

• 0ecb892 — Update resources (2026.420.0)
• c148e20 — Fix illegible star rating text colour in ranked play intro (Fix illegible star rating text colour in ranked play intro animation ppy/osu#37429)

Conflict: kept fork's ProjectReference to framework submodule, updated ppy.osu.Game.Resources to 2026.420.0.

Release workflow: optional keystore upload

Added keystore_base64, key_alias, key_password inputs to workflow_dispatch. Users can paste values from SAVE-THESE-SECRETS.txt directly into the "Run workflow" form instead of configuring repo secrets. Priority chain: workflow inputs → repo secrets → auto-generate.

---

Summary by Gitar

• Visual refinements:
  • Improved StarRatingSequence UI by using OverlayColourProvider and adding a proxy to fix masking issues.
  • Added a visual test scene TestSceneStarRatingSequence to verify the star rating appearance.
• Dependencies:
  • Bumped ppy.osu.Game.Resources from 2026.411.0 to 2026.420.0.

_{This will update automatically on new commits.}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[Copilot]

Pull request overview

Updates ranked play intro visuals and Android release pipeline ergonomics, alongside bumping the resources package version (PR description also mentions Android Vulkan surface crash hardening in the framework submodule).

Changes:

• Bump ppy.osu.Game.Resources to 2026.420.0.
• Adjust StarRatingSequence styling/colouring to use OverlayColourProvider shades and improve high-star text legibility.
• Add optional keystore-related workflow_dispatch inputs and selection priority logic in release.yml.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

File	Description
osu.Game/osu.Game.csproj	Bumps resources package version to align with upstream.
osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs	Uses overlay theme colours and adjusts star-rating text colouring + proxy to avoid masking.
osu.Game.Tests/Visual/RankedPlay/TestSceneStarRatingSequence.cs	Adds a visual test scene for basic StarRatingSequence appearance/playback.
.github/workflows/release.yml	Adds workflow inputs for keystore material and implements input/secret/autogen priority logic.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The workflow_dispatch inputs keystore_base64, key_alias, and key_password are not secret-protected by GitHub Actions (their values are stored in the workflow run metadata and may be visible to anyone with access to the run). Using them for an Android signing keystore/password risks leaking the private signing key. Consider removing these inputs and only supporting repository/environment secrets (or another secret-protected mechanism) for providing signing material.

Suggested change

	keystore_base64:
	description: "Base64-encoded keystore (from SAVE-THESE-SECRETS.txt). Overrides ANDROID_KEYSTORE_BASE64 secret."
	required: false
	default: ""
	type: string
	key_alias:
	description: "Signing key alias (from SAVE-THESE-SECRETS.txt). Overrides ANDROID_SIGNING_KEY_ALIAS secret."
	required: false
	default: ""
	type: string
	key_password:
	description: "Signing key password (from SAVE-THESE-SECRETS.txt). Overrides ANDROID_SIGNING_KEY_PASSWORD secret."
	required: false
	default: ""
	type: string

[Copilot]

When a user-provided keystore is used, the base64 keystore content itself is still highly sensitive (it contains the private key). Even if this step doesn’t currently print it, it’s safer to mask EFFECTIVE_KS/INPUT_KEYSTORE_BASE64 via ::add-mask:: to avoid accidental leakage via debugging or error output.

[Copilot]

If EFFECTIVE_KS is set but EFFECTIVE_PASS (and/or EFFECTIVE_ALIAS) is empty, the workflow will continue and dotnet publish will receive empty signing parameters, which will likely fail later with a less actionable error. Add an explicit validation/early-exit here to require the necessary password/alias fields whenever a keystore is provided.