Fix osu-framework submodule pointing to non-existent commit - #220
Merged
Conversation
The submodule was pointing to commit c85f1debf4 which doesn't exist in the winnerspiros/osu-framework remote (likely created locally but never pushed). Update to the latest master (8097681) which includes all critical fixes: DrawFrame surface guard, veldrid-spirv fork, NRE fixes, perf optimizations, and iOS pack fixes. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
April 20, 2026 17:42
View session
There was a problem hiding this comment.
Pull request overview
Fixes CI/build failures caused by the submodules/osu-framework git submodule referencing a non-existent commit by repointing the submodule to a valid upstream commit on winnerspiros/osu-framework.
Changes:
- Update
submodules/osu-frameworksubmodule pointer from the phantom commit (c85f1de…) to8097681…(upstream master).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Build Android APK" workflow fails at submodule checkout because
submodules/osu-frameworkreferences commitc85f1debf4which doesn't exist in the remote — it was created locally (likely a merge) but never pushed.Fix
8097681bfb(winnerspiros/osu-frameworkmaster), which already contains all the fixes the phantom commit was meant to include: surface-ready guard, veldrid-spirv fork, NRE fixes, perf optimizations, iOS pack fixesSanity check
Full audit of the codebase confirmed no other issues:
release.yml,ci.yml), build props — correct.slnffiles,local-packages/nupkg,NuGet.Config— present and valid