-
Notifications
You must be signed in to change notification settings - Fork 0
Investigating build failure and framework issue #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,9 @@ jobs: | |
| name: Pack | ||
| runs-on: ubuntu-latest | ||
| environment: production | ||
| permissions: | ||
| contents: read | ||
| packages: read | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
@@ -55,6 +58,9 @@ jobs: | |
| with: | ||
| dotnet-version: "10.0.x" | ||
|
|
||
| - name: Authenticate to GitHub Packages | ||
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | ||
|
|
||
|
Comment on lines
+61
to
+63
|
||
| - name: Pack | ||
| run: | | ||
| # Replace project references in templates with package reference, because they're included as source files. | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -40,11 +40,11 @@ jobs: | |||||||||||||||||||||||||||||||
| timeout-minutes: 60 | ||||||||||||||||||||||||||||||||
| permissions: | ||||||||||||||||||||||||||||||||
| contents: write | ||||||||||||||||||||||||||||||||
| packages: read | ||||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||||
| - name: Checkout | ||||||||||||||||||||||||||||||||
| uses: actions/checkout@v6 | ||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||
| submodules: recursive | ||||||||||||||||||||||||||||||||
| fetch-depth: 0 | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| - name: Setup JDK 17 | ||||||||||||||||||||||||||||||||
|
|
@@ -61,6 +61,9 @@ jobs: | |||||||||||||||||||||||||||||||
| - name: Install .NET Android workload | ||||||||||||||||||||||||||||||||
| run: dotnet workload install android | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| - name: Authenticate to GitHub Packages | ||||||||||||||||||||||||||||||||
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
| run: dotnet nuget update source winnerspiros-github --username ${{ github.actor }} --password ${{ secrets.GITHUB_TOKEN }} --store-password-in-clear-text | |
| run: | | |
| NUGET_CONFIG_FILE="$RUNNER_TEMP/NuGet.Config" | |
| cat > "$NUGET_CONFIG_FILE" <<'EOF' | |
| <?xml version="1.0" encoding="utf-8"?> | |
| <configuration> | |
| </configuration> | |
| EOF | |
| dotnet nuget add source "https://nuget.pkg.github.com/winnerspiros/index.json" \ | |
| --name winnerspiros-github \ | |
| --username "${{ github.actor }}" \ | |
| --password "${{ secrets.GITHUB_TOKEN }}" \ | |
| --store-password-in-clear-text \ | |
| --configfile "$NUGET_CONFIG_FILE" | |
| echo "NUGET_CONFIG_FILE=$NUGET_CONFIG_FILE" >> "$GITHUB_ENV" |
Copilot
AI
Apr 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The native library verification here only checks that the required .so files are present. Previously there was also an ABI/compatibility validation to ensure libbass.so was the Android build (not a desktop/Linux variant), which helps catch hard-to-debug startup crashes. Consider reintroducing an equivalent compatibility check (e.g., extracting and inspecting libbass.so with readelf).
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2,9 +2,8 @@ | |||||||||||||||||||
| <configuration> | ||||||||||||||||||||
| <packageSources> | ||||||||||||||||||||
| <clear /> | ||||||||||||||||||||
| <!-- winnerspiros/veldrid-spirv fork NuGet package (included in local-packages/). | ||||||||||||||||||||
| Source: https://github.com/winnerspiros/veldrid-spirv/releases --> | ||||||||||||||||||||
| <add key="local-packages" value="local-packages" /> | ||||||||||||||||||||
| <!-- winnerspiros/osu-framework fork NuGet packages (published to GitHub Packages) --> | ||||||||||||||||||||
|
||||||||||||||||||||
| <!-- winnerspiros/osu-framework fork NuGet packages (published to GitHub Packages) --> | |
| <!-- | |
| winnerspiros/osu-framework fork NuGet packages (published to GitHub Packages). | |
| Local restore requires authenticating this source first, for example: | |
| dotnet nuget update source winnerspiros-github --username YOUR_GITHUB_USERNAME --password YOUR_GITHUB_TOKEN --store-password-in-clear-text | |
| If the source has not been added yet, use: | |
| dotnet nuget add source https://nuget.pkg.github.com/winnerspiros/index.json --name winnerspiros-github --username YOUR_GITHUB_USERNAME --password YOUR_GITHUB_TOKEN --store-password-in-clear-text | |
| The GitHub token should include at least the `read:packages` scope; add `repo` as well if the package/repository is private. | |
| --> |
Copilot
AI
Apr 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that the framework submodule is removed and replaced with a GitHub Packages feed, README.md still contains submodule-based setup instructions (e.g., cloning with --recurse-submodules / “Framework as submodule”). Please update the docs to match the new NuGet-based setup to avoid confusing contributors.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow authenticates to GitHub Packages using
dotnet nuget update source ... --store-password-in-clear-text, which writes the token into a NuGet.Config file in plain text. To reduce the risk of accidental token exposure (e.g., if the workspace/config is ever uploaded), consider writing credentials to a temporary config under$RUNNER_TEMPand passing--configfileto restore/build, then deleting it after.