Android Performance settings: trim crash-related toggles, expand Oboe hint - #263
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/038b173b-d81a-412c-8c3e-3471eb8bab2e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/038b173b-d81a-412c-8c3e-3471eb8bab2e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…restore Vulkan in dropdown Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/038b173b-d81a-412c-8c3e-3471eb8bab2e Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…cation, verbose-logging toggle, settings cleanup Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/1ba21ebe-2c45-4249-b1c7-a8751be54098 Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…d explanation Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/9257036d-08c5-4407-a482-43662460410f Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
winnerspiros
April 23, 2026 19:40
View session
winnerspiros
marked this pull request as ready for review
April 23, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android Performance settings page exposed four toggles that gate startup safety nets or cosmetic native probes — disabling any of them only re-introduces previously-fixed crashes, so they shouldn't be user-facing. Separately, the "Low-latency audio (Oboe)" hint didn't explain what the toggle actually does on hover.
Settings cleanup (
osu.Game/Overlays/Settings/Sections/Graphics/AndroidPerformanceSettings.cs)Removed four
FormCheckBoxitems from the UI:OsuSetting.AndroidVulkanProbe) — cosmetic; only queries Vulkan capability info via the native bridge, never switches the renderer.OsuSetting.AndroidCleanupStaleRealmFifos) — safety net for the previously-fixed Realm-fifo crash.OsuSetting.AndroidDeferStartupNativeInit) — cold-start safety net.OsuSetting.AndroidStartupFrameSyncMigrationEnabled) — silently mutated framework defaults; the original bug it worked around is fixed elsewhere.The underlying
OsuSettingentries are intentionally retained with their existing defaults (probe OFF, fifo cleanup ON, defer-init ON, FrameSync migration OFF) soOsuGameAndroid'sBindWithandmirrorStartupFlagwiring continues to resolve without conditional registration. An inline comment documents the removal rationale.Oboe hint expansion
Replaced the one-liner on the remaining "Low-latency audio (Oboe)" toggle with a description that covers the AAudio + MMAP fast path, the expected ~80–150ms → ~20–40ms latency drop on supported hardware, the audio-offset auto-suggestion driven by reported hardware latency, the graceful fallback to the default mixer with an entry written to
runtime.logon failure, and when a user might want to disable it (crackles / drop-outs / wrong-pitch on a specific device).No behaviour changes outside the settings UI.
Summary by Gitar
PlatformNotSupportedExceptionhandling forGCSettings.LatencyModeto prevent crashes on unsupported Android runtimes.Verbose loggingtoggle to controlLogLeveland reduce disk I/O.Debug.WriteLinecalls in Android native bridges toLogger.Logfor persistent reporting.RendererSettingsregarding Vulkan on Adreno hardware.This will update automatically on new commits.