Skip to content

fix: eliminate storyboard atlas overflow GPU stalls + bump framework to 2026.503.7 #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winnerspiros merged 2 commits into from
May 3, 2026
Merged

fix: eliminate storyboard atlas overflow GPU stalls + bump framework to 2026.503.7 #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fad0842
fix: use LargeTextureStore in DrawableStoryboard to eliminate atlas o…
Copilot May 3, 2026
2943a36
chore: bump ppy.osu.Framework to 2026.503.7
Copilot May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osu.Android.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="ppy.osu.Framework.Android" Version="2026.503.6" />
<PackageReference Include="ppy.osu.Framework.Android" Version="2026.503.7" />
<!-- `ppy.osu.Framework.NativeLibs` is a transitive dependency of `ppy.osu.Framework`
that ships desktop-only natives (Linux/macOS/Windows) under `runtimes/<rid>/native/`
— including a bare Linux `libbass.so`/`libbass_fx.so`/`libbassmix.so` for linux-arm64.
Expand Down
11 changes: 9 additions & 2 deletions osu.Game/Storyboards/Drawables/DrawableStoryboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,17 @@ private void load(IGameplayClock? clock, CancellationToken? cancellationToken, G
if (clock != null)
Clock = clock;

// Storyboard assets are per-beatmap images (backgrounds, sprites, animations) that are
// typically large (e.g. 1920×1080, 2732×1572) and are loaded once per play session.
// Using a regular atlased TextureStore causes a storm of atlas overflow events during
// beatmap load (one new 2048×2048 GPU texture + vkQueueSubmit per overflow, 8+ times in
// ~5 seconds), each stalling the render thread and dropping FPS.
// LargeTextureStore skips atlasing entirely so every storyboard asset gets its own GPU
// texture with no atlas packing, eliminating all overflow stalls on Android Vulkan.
dependencies.CacheAs(typeof(TextureStore),
new TextureStore(host.Renderer, host.CreateTextureLoaderStore(
new LargeTextureStore(host.Renderer, host.CreateTextureLoaderStore(
CreateResourceLookupStore()
), false, scaleAdjust: 1));
)));

foreach (var layer in Storyboard.Layers)
{
Expand Down
4 changes: 2 additions & 2 deletions osu.Game/osu.Game.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Realm" Version="20.1.0" />
<PackageReference Include="ppy.osu.Framework" Version="2026.503.6" />
<PackageReference Include="ppy.osu.Framework" Version="2026.503.7" />
<!--
Explicitly pin `ppy.Veldrid.SPIRV` to the winnerspiros fork build that
`ppy.osu.Framework 2026.503.6` was compiled against. This version is the only
`ppy.osu.Framework 2026.503.7` was compiled against. This version is the only
one whose `runtimes/android-arm64/native/libveldrid-spirv.so` is aligned to 16 KB
pages (required by Android 16+). It lives only as a release asset on
<https://github.com/winnerspiros/veldrid-spirv/releases/tag/1.0> and is vendored
Expand Down
2 changes: 1 addition & 1 deletion osu.iOS.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@
<SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Framework.iOS" Version="2026.503.6" />
<PackageReference Include="ppy.osu.Framework.iOS" Version="2026.503.7" />
</ItemGroup>
</Project>
Loading