Tighten gameplay hot paths by removing redundant hitobject traversal in note-lock and hitsound selection

[Copilot]

The issue was unnecessary per-input work in gameplay-critical logic, with the constraint to keep observable behavior unchanged. This change re-reviews and simplifies traversal paths, including removing fallback paths where they do not alter outcomes.

• StartTimeOrderedHitPolicy: top-level, time-bounded scan

  • Limits blocking/miss checks to top-level alive objects before the target time.
  • Keeps note-lock semantics unchanged (DrawableHitCircle remains the only blocker).
  • Reduces work in dense slider-heavy sections by avoiding irrelevant traversal.

• GameplaySampleTriggerSource: single-pass candidate/bounds selection

  • Replaces repeated entry scans with single-pass min/max bound resolution.
  • Selects the next valid lifetime entry without redundant passes.
  • Removes unnecessary fallback handling where result selection is unchanged.

• Nested hitsound lookup: allocation-aware traversal

  • Uses iterative traversal with a reusable scratch list for nested objects.
  • Preserves “earliest valid nested sample” behavior while reducing per-call overhead and GC pressure.

private (HitObjectLifetimeEntry? first, HitObjectLifetimeEntry? last) getEntryBounds()
{
    HitObjectLifetimeEntry? first = null;
    HitObjectLifetimeEntry? last = null;

    foreach (var entry in hitObjectContainer.Entries)
    {
        if (first == null || entry.HitObject.StartTime < first.HitObject.StartTime)
            first = entry;

        if (last == null || entry.HitObject.StartTime > last.HitObject.StartTime)
            last = entry;
    }

    return (first, last);
}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.