Skip to content

Android: remove duplicate ADPF orchestration from game thread path - #350

Merged
winnerspiros merged 1 commit into
masterfrom
copilot/fix-apk-crash-issue-448ca0d0-8351-40d7-872f-930dcfb6b287
May 23, 2026
Merged

Android: remove duplicate ADPF orchestration from game thread path#350
winnerspiros merged 1 commit into
masterfrom
copilot/fix-apk-crash-issue-448ca0d0-8351-40d7-872f-930dcfb6b287

Conversation

Copilot AI commented May 23, 2026

Copy link
Copy Markdown

Startup/input ANRs were traced to overlapping performance-hint control paths on Android. We now keep a single hinting path (Oboe-managed) and remove redundant managed/native ADPF session reporting that was running on the game thread.

  • What changed

    • Removed manual ADPF session lifecycle in OsuGameAndroid (init/update/report/dispose hooks tied to frame completion).
    • Removed ADPF interop surface from OboeAudioBridge.cs and matching native exports in oboe_bridge.cpp.
    • Kept Oboe stream performance hinting enabled as the sole mechanism for ADPF integration.
  • Why this shape

    • Eliminates duplicate scheduling signals and hot-path interop churn in frame/input code.
    • Reduces contention risk while preserving low-latency audio performance hints through Oboe.
// Retained single performance-hint path in native audio stream setup.
stream_->setPerformanceHintEnabled(true);

Agent-Logs-Url: https://github.com/winnerspiros/osu/sessions/b363e225-1c7b-4b79-9b10-affbb8444d57

Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
@winnerspiros
winnerspiros marked this pull request as ready for review May 23, 2026 06:20
Copilot AI review requested due to automatic review settings May 23, 2026 06:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@winnerspiros
winnerspiros merged commit 8fe5508 into master May 23, 2026
15 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants