Fix IL trimming warnings and iOS CI build failure - #364
Merged
winnerspiros merged 1 commit intoMay 28, 2026
Conversation
Copilot
AI
changed the title
Fix IL trimming warnings and iOS build failure
Fix IL trimming warnings and iOS CI build failure
May 28, 2026
Copilot created this pull request from a session on behalf of
winnerspiros
May 28, 2026 18:37
View session
winnerspiros
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI reported 1 iOS build error and 30 IL trimming warnings (IL2026/IL2057/IL2072/IL2075) across
osu.Gameandosu.Game.Tournament, plus an informational Windows runner redirect notice.Trimming warnings
Added
[DynamicallyAccessedMembers]or[UnconditionalSuppressMessage]to the 10 affected call sites:SerialisedDrawableInfo.Type[DynamicallyAccessedMembers(PublicParameterlessConstructor)]on property — annotation flows to all callersWizardOverlay.ShowNextStep(),ScreenWhiteBox()ctor,IMod.CreateInstance()[UnconditionalSuppressMessage]ModSpeedHotkeyHandler.ChangeSpeed()[UnconditionalSuppressMessage]SkinInfo.CreateInstance(),RealmRulesetStore.prepareDetachedRulesets(),RulesetInfo.CreateInstance()[UnconditionalSuppressMessage]TournamentGameBase.readBracket(),GetSerialisedLadder(),StableInfoctor,SaveChanges()[UnconditionalSuppressMessage]iOS build error
dotnet workload install ios(no version pin) fetchedMicrosoft.iOS.Sdk.net10.0_26.5from NuGet, which requires Xcode 26.5 — the runner only has 16.4. Added--skip-manifest-updateto use the SDK manifests bundled with the installed .NET 10 toolchain instead.