Skip to content

Fix Android Native Vulkan compilation error #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winnerspiros merged 1 commit into from
Feb 5, 2026
Merged

Fix Android Native Vulkan compilation error #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions osu.Android/Native/vulkan_renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,14 @@ VulkanRenderer::~VulkanRenderer() {
LOGI("VulkanRenderer destroyed");
}

void VulkanRenderer::init(ANativeWindow* window) {
bool VulkanRenderer::initialize(ANativeWindow* window) {
// Vulkan initialization: Instance, Surface, Physical Device, Logical Device, Swapchain (2 images, MAILBOX)
LOGI("Vulkan initialized with window %p", window);
return true;
}

void VulkanRenderer::cleanup() {
LOGI("VulkanRenderer cleanup");
}

void VulkanRenderer::render() {
Expand All @@ -43,8 +48,7 @@ extern "C" {
bool nVulkanInitialize(long rendererPtr, void* window) {
VulkanRenderer* renderer = (VulkanRenderer*)rendererPtr;
if (!renderer || !window) return false;
renderer->init((ANativeWindow*)window);
return true;
return renderer->initialize((ANativeWindow*)window);
}

void nVulkanRender(long rendererPtr) {
Expand All @@ -65,7 +69,7 @@ extern "C" {
VulkanRenderer* renderer = (VulkanRenderer*)rendererPtr;
if (!renderer || !surface) return;
ANativeWindow* window = ANativeWindow_fromSurface(env, surface);
renderer->init(window);
renderer->initialize(window);
}

JNIEXPORT void JNICALL Java_osu_Android_Native_VulkanRenderer_nVulkanRender(JNIEnv* env, jobject obj, jlong rendererPtr) {
Expand Down