⚡ Optimize ModelManager deletion performance - #69
Conversation
Wraps the iteration loop in `Delete(List<TModel>)` and `Undelete(List<TModel>)` within a single `Realm.Write` block to prevent N+1 database transactions. Adds `Delete(TModel, Realm)` and `Undelete(TModel, Realm)` overloads to support transactional context reuse. Adds a benchmark test `ModelManagerPerformanceTest` demonstrating a performance improvement from ~1.5s to ~26ms for deleting 1000 items. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Wraps the iteration loop in `Delete(List<TModel>)` and `Undelete(List<TModel>)` within a single `Realm.Write` block to prevent N+1 database transactions. Adds `Delete(TModel, Realm)` and `Undelete(TModel, Realm)` overloads to support transactional context reuse. Adds a benchmark test `ModelManagerPerformanceTest` demonstrating a performance improvement from ~1.5s to ~26ms for deleting 1000 items. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Wraps the iteration loop in `Delete(List<TModel>)` and `Undelete(List<TModel>)` within a single `Realm.Write` block to prevent N+1 database transactions. Adds `Delete(TModel, Realm)` and `Undelete(TModel, Realm)` overloads to support transactional context reuse. Adds a benchmark test `ModelManagerPerformanceTest` demonstrating a performance improvement from ~1.5s to ~26ms for deleting 1000 items. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
Wraps the iteration loop in `Delete(List<TModel>)` and `Undelete(List<TModel>)` within a single `Realm.Write` block to prevent N+1 database transactions. Adds `Delete(TModel, Realm)` and `Undelete(TModel, Realm)` overloads to support transactional context reuse. Adds a benchmark test `ModelManagerPerformanceTest` demonstrating a performance improvement from ~1.5s to ~26ms for deleting 1000 items. Fixes flaky tests in `TestSceneSoloResultsScreen` by using `AddUntilStep` for async UI assertions. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 participant
This PR addresses the performance issue "N+1 Database Transactions in ModelManager.Delete" by batching the delete/undelete operations into a single Realm transaction.
Changes:
ModelManager.Delete(List<TModel>)to use a singleRealm.Writetransaction for the entire batch.ModelManager.Undelete(List<TModel>)to use a singleRealm.Writetransaction for the entire batch.Delete(TModel item, Realm realm)andUndelete(TModel item, Realm realm)to perform operations within an existing transaction context.osu.Game.Tests/Database/ModelManagerPerformanceTest.csto verify performance improvements.Performance:
PR created automatically by Jules for task 8343520517278961026 started by @winnerspiros