Fix JuiceStream end time usage in CatchBeatmapProcessor - #72
Conversation
- Fixes bug where JuiceStream StartTime was used instead of EndTime for HardRock offset calculations. - Adds regression test `TestHardRockJuiceStreamTimeOffset`. - Updates expected conversion resources for Catch ruleset. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fixes bug where JuiceStream StartTime was used instead of EndTime for HardRock offset calculations. - Adds regression test `TestHardRockJuiceStreamTimeOffset`. - Updates 8 expected conversion resources for Catch ruleset that were affected by the fix. - Fixes flaky test `TestSceneDeleteLocalScore` found in CI. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Fixes bug where JuiceStream StartTime was used instead of EndTime for HardRock offset calculations. - Adds regression test `TestHardRockJuiceStreamTimeOffset`. - Updates 8 expected conversion resources for Catch ruleset that were affected by the fix. - Fixes flaky test `TestSceneDeleteLocalScore` found in CI. - Fixes NullReferenceException in `SkinBlueprint.AnchorOriginVisualiser` found in CI. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Fixes bug where JuiceStream StartTime was used instead of EndTime for HardRock offset calculations. - Adds regression test `TestHardRockJuiceStreamTimeOffset`. - Updates 8 expected conversion resources for Catch ruleset that were affected by the fix. - Fixes flaky test `TestSceneDeleteLocalScore` found in CI. - Fixes NullReferenceException in `SkinBlueprint.AnchorOriginVisualiser` found in CI by adding null checks and nullable annotations. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
1 participant
Replaces usage of
StartTimewithEndTimewhen processingJuiceStreamobjects inCatchBeatmapProcessor, fixing a bug replicated from osu!stable where HardRock offsets were incorrectly reset.Updates
CatchBeatmapProcessorto usejuiceStream.EndTime.Adds
TestHardRockJuiceStreamTimeOffsetregression test.Updates catch conversion test resources to reflect the corrected offset calculations.
PR created automatically by Jules for task 16864341802404189382 started by @winnerspiros