Fix Android crash by implementing Vulkan and Oboe initialization - #74
Merged
Conversation
- Implemented longest-prefix matching for variable expansion to support suffixes (e.g., $var56 -> value56). - Fixed CS8600 warning (nullable reference types). - Fixed CA1846 warning (prefer AsSpan). - Verified with LegacyStoryboardDecoderTest. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Fixed formatting (IDE0055) and implicit type warning (IDE0008) in `LegacyStoryboardDecoder.cs`. - Updated `global.json` to use `rollForward: latestFeature` to ensure .NET 8 SDK is used instead of rolling forward to incompatible .NET 10 previews on CI. - Verified fixes with `dotnet format` and unit tests. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Updated `osu.Android/Native/VulkanRenderer.cs` to accept `IntPtr` for `Initialize`, matching the `Window.Handle` passed from `OsuGameAndroid.cs` and resolving the `cannot convert from 'nint' to 'Android.Views.Surface'` compilation error. - Fixed code style (blank lines) in `LegacyStoryboardDecoder.cs`. - Retained the CI fix for SDK version (rollForward: latestFeature). Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Updated `osu.Android/Native/VulkanRenderer.cs` to accept `IntPtr` for `Initialize`, matching the `Window.Handle` passed from `OsuGameAndroid.cs` and resolving the `cannot convert from 'nint' to 'Android.Views.Surface'` compilation error. - Fixed code style (blank lines) in `LegacyStoryboardDecoder.cs`. - Retained the CI fix for SDK version (rollForward: latestFeature). Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
- Inserted missing blank lines in `LegacyStoryboardDecoder.cs` (lines 393, 428) to comply with CodeFileSanity checks. - Updated `VulkanRenderer.Initialize` to accept `IntPtr` to match the window handle passed from `OsuGameAndroid.cs`, resolving the CS1503 compilation error. - Verified formatting with `dotnet format`. Co-authored-by: winnerspiros <1675249+winnerspiros@users.noreply.github.com>
…les-11597934844821820705 Fix LegacyStoryboardDecoder variable substitution with suffixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.