Fix Android findSurfaceView warning and add iOS CI signing - #77
Conversation
- Update `osu.Android/OsuGameActivity.cs`: - `findSurfaceView` now accepts `View?` and handles null values to resolve nullable warning. - Update `.github/workflows/release.yml`: - Add `IOS_CERTIFICATE`, `IOS_CERTIFICATE_PASSWORD`, `IOS_PROVISION_PROFILE` to `build-ios` job. - Add step to decode and import certificates/profiles to a temporary keychain if secrets are present. - Split `Build iOS` into conditional "Signed" (if secrets exist) and "Unsigned" (if secrets missing) steps. - Use `base64 --decode` for secret decoding on macOS runner.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change addresses two issues:
osu.Android/OsuGameActivity.csby updatingfindSurfaceViewto accept a nullableView?and explicitly checking for null.build-iosjob now conditionally imports code signing certificates and provisioning profiles from secrets (IOS_CERTIFICATE,IOS_PROVISION_PROFILE) if present, and performs a signed build. If secrets are missing, it falls back to an unsigned build to prevent workflow failure.PR created automatically by Jules for task 9051735352926460392 started by @winnerspiros