aa

[winnerspiros]

Summary by CodeRabbit

• Bug Fixes

  • Gameplay readiness now requires the game window to be active.

• Style

  • Beatmap set display in song selection now animates margin transitions smoothly when toggling visibility.
  • Filter control layout has been restructured for improved visual consistency and spacing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c9c0e0be-69d7-41a5-abe0-ba92a50e160e

📥 Commits

Reviewing files that changed from the base of the PR and between 383264f and 7b99842.

📒 Files selected for processing (3)

• osu.Game/Screens/Play/PlayerLoader.cs
• osu.Game/Screens/Select/FilterControl.ScopedBeatmapSetDisplay.cs
• osu.Game/Screens/Select/FilterControl.cs

---

📝 Walkthrough

Walkthrough

The changes add host activity checks to gameplay readiness logic, introduce margin animations for filter control state transitions, and restructure the filter UI layout using nested flow containers for improved organization.

Changes

Cohort / File(s)	Summary
Gameplay Readiness Condition osu.Game/Screens/Play/PlayerLoader.cs	Added GameHost dependency and updated ReadyForGameplay logic to require host.IsActive.Value == true alongside existing hover/idle/input-focus and drag conditions.
Filter UI Layout & Animation osu.Game/Screens/Select/FilterControl.cs, osu.Game/Screens/Select/FilterControl.ScopedBeatmapSetDisplay.cs	Restructured filter control layout into nested ReverseChildIDFillFlowContainer<Drawable> with explicit vertical direction and spacing. Added margin animations in ScopedBeatmapSetDisplay.updateState() during state transitions with easing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

A rabbit hops through UI lands so fair,
Adding checks so the game knows we're there! 🐰
Margins dance with a flourish and flair,
Containers reshape with organized care,
Smooth animations float through the air! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adjusts song-select filter UI layout/spacing around the scoped beatmap set indicator, and prevents gameplay from starting while the host window is inactive.

Changes:

• Refactors FilterControl layout to apply spacing only between filter controls (not between controls and the scoped set display).
• Animates ScopedBeatmapSetDisplay margin to introduce/remove vertical separation only when the scoped set is active.
• Gates PlayerLoader’s “ready for gameplay” condition on GameHost.IsActive.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
osu.Game/Screens/Select/FilterControl.cs	Reworks container hierarchy to localise vertical spacing to the main filter controls.
osu.Game/Screens/Select/FilterControl.ScopedBeatmapSetDisplay.cs	Adds margin transforms to create conditional spacing when a scoped set is shown/hidden.
osu.Game/Screens/Play/PlayerLoader.cs	Requires host to be active before considering gameplay “ready”, preventing background-start pushes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.