Skip to content

planner: testing the ExtractFD just after the plan building phase#6

Open
winoros wants to merge 3 commits into
functional-dependencyfrom
modify-tests
Open

planner: testing the ExtractFD just after the plan building phase#6
winoros wants to merge 3 commits into
functional-dependencyfrom
modify-tests

Conversation

@winoros

@winoros winoros commented Feb 16, 2022

Copy link
Copy Markdown
Owner

What problem does this PR solve?

To support only_full_group_by checking and to test the basic usage. We just test the FD result after the plan building phase.

What is changed and how it works?

Check List

Tests

  • No code

@winoros winoros requested a review from AilinKid February 16, 2022 17:59
@winoros winoros changed the title planner: refactor the interface of the LogicalPlan planner: testing the ExtractFD just after the plan building phase Feb 22, 2022
{
sql: "select * from x1 where c = d group by b, c",
best: "DataScan(x1)->Aggr(firstrow(test.x1.a),firstrow(test.x1.b),firstrow(test.x1.c),firstrow(test.x1.d))->Projection",
best: "DataScan(x1)->Sel([eq(test.x1.c, test.x1.d)])->Aggr(firstrow(test.x1.a),firstrow(test.x1.b),firstrow(test.x1.c),firstrow(test.x1.d))->Projection",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem need to show 4 item fd here? A>>>B>>>C>>>D

@AilinKid AilinKid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

winoros pushed a commit that referenced this pull request Mar 4, 2026
*: materialized view refresh optimizer updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants