Conversation
fewerner
force-pushed
the
felix/ts-benchmarks
branch
from
ec8091d to
45e42d9
Compare
fewerner
force-pushed
the
felix/ts-benchmarks
branch
3 times, most recently
from
6dd867b to
d8f1787
Compare
We used to copy the files under out into a temporary directory. Instead of doing this we can mount the `out` dir directly as it contains the correct folder structure already + the index.html for the the browser url.
We separate wdio configs for tests and benchmarks as benchmarks will usually run much longer. Also we mount the tinybench module for benchmarks which should not be included in tests. We remove the spec option from make rules as specs are defined by the config files already.
We want to clearly separate benchmark and test implementations. We define window parameters needed to run tinybench benchmarks. `benchmark_paramaters` demonstrates how we can build an Array of parametersets which we can later send to the browser to add benchmarks for each combination. We are allowed to do this because size, count and ciphersuite are numbers.
fewerner
force-pushed
the
felix/ts-benchmarks
branch
from
d8f1787 to
5a6c812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR sets up tinybench benchmarks for wdio and adds the first benchmark for creating messages.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.