feat: better error on duplicate signature#1962
Merged
Conversation
typfel
force-pushed
the
feat/duplicate-signature-WPB-24050
branch
3 times, most recently
from
f21a8d2 to
fa6692d
Compare
coriolinus
approved these changes
Mar 24, 2026
Contributor
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
A few nits, but nothing blocking. Nice to see this!
typfel
force-pushed
the
feat/duplicate-signature-WPB-24050
branch
from
084b5dd to
584b8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Improve the error we return upon discovering duplicate signatures to aid in debugging the root cause.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.