refactor: align db and pki env constructors in rust where possible [WPB-24153]#1969
Merged
coriolinus merged 13 commits intomainfrom Mar 23, 2026
Conversation
SimonThormeyer
force-pushed
the
prgn/refactor/24153-align-db-and-pki-env-constructors-in-rust-where-possible
branch
4 times, most recently
from
1fd1b26 to
dfbebd3
Compare
This gives us the real constuctors we want for that platform at least. We'd really prefer to have them everywhere, but non-wasm is still using uniffi v0.29, and async static constructors only begin support in uniffi from v0.30. On non-wasm we still export the free functions and will have to wrap them.
SimonThormeyer
changed the title
This gives us the real constuctor we want for that platform at least. We'd really prefer to have it everywhere, but non-wasm is still using uniffi v0.29, and async static constructors only begin support in uniffi from v0.30. On non-wasm we still export the free function and will have to wrap it.
…ree function This should work, but we have to run it through CI to see for sure.
coriolinus
force-pushed
the
prgn/refactor/24153-align-db-and-pki-env-constructors-in-rust-where-possible
branch
from
c513185 to
6760932
Compare
coriolinus
approved these changes
Mar 23, 2026
coriolinus
deleted the
prgn/refactor/24153-align-db-and-pki-env-constructors-in-rust-where-possible
branch
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.