Skip to content

refactor(ts): share wrapper code [WPB-24209]#1984

Merged
SimonThormeyer merged 7 commits intomainfrom
simon/refactor/deduplicate-ts-wrappers-WPB-24209
Mar 26, 2026
Merged

refactor(ts): share wrapper code [WPB-24209]#1984
SimonThormeyer merged 7 commits intomainfrom
simon/refactor/deduplicate-ts-wrappers-WPB-24209

Conversation

@SimonThormeyer
Copy link
Copy Markdown
Member

@SimonThormeyer SimonThormeyer commented Mar 26, 2026 •
edited
Loading

What's new in this PR

See title

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer changed the title Simon/refactor/deduplicate ts wrappers wpb 24209 refactor(ts): share wrapper code [WPB-24209] Mar 26, 2026
@SimonThormeyer
build(ts): add conditioned import to package.json [WPB-24209]
fba01f7 
Depending on the condition, either the browser bindings or the native
bindings will be selected for import.
@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/deduplicate-ts-wrappers-WPB-24209 branch 2 times, most recently from eca9895 to 46e78e6 Compare March 26, 2026 13:09
@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/deduplicate-ts-wrappers-WPB-24209 branch 2 times, most recently from 0b46d86 to 18bfb71 Compare March 26, 2026 13:38
@SimonThormeyer SimonThormeyer marked this pull request as ready for review March 26, 2026 13:43
@SimonThormeyer SimonThormeyer requested a review from a team March 26, 2026 13:43
@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/deduplicate-ts-wrappers-WPB-24209 branch 2 times, most recently from fee7f32 to 7b6abef Compare March 26, 2026 13:55
coriolinus
coriolinus approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! This looks pretty clean overall, and I'm delighted that we won't be maintaining two entirely distinct but nearly identical TS projects.

@SimonThormeyer SimonThormeyer force-pushed the simon/refactor/deduplicate-ts-wrappers-WPB-24209 branch from 90387bb to 4ea92e9 Compare March 26, 2026 14:19
@SimonThormeyer SimonThormeyer merged commit 4ea92e9 into main Mar 26, 2026
55 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/refactor/deduplicate-ts-wrappers-WPB-24209 branch March 26, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SimonThormeyer @coriolinus