test: convert more tests to use the new X509 acquisition process#1993
Merged
istankovic merged 9 commits intomainfrom Mar 31, 2026
Merged
test: convert more tests to use the new X509 acquisition process#1993istankovic merged 9 commits intomainfrom
istankovic merged 9 commits intomainfrom
Conversation
…alAcquisition::try_new
…types Here we're removing the check for matching public key bytes because it only worked for P256, and we want it to work for all key types and, importantly, to be an integral part of the acquisition process such that it is not possible to obtain a certificate if the public key bytes do not match.
We don't actually need it and we're going to revisit the flow documentation anyway, probably moving it to the CoreCrypto book.
…ocess We don't have the demo anymore.
One day we will spawn only one step-ca instance, but that day has not come yet.
Otherwise we run into race conditions with parallel tests and a single test-wire-server process.
typfel
reviewed
Mar 31, 2026
typfel
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only leaves
should_fail_when_certificate_path_doesnt_contain_trust_anchor, which requires changes toPkiEnviroment(we need to be able to configure trust anchors).