Conversation
.github/workflows/benchmarks_new.yml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Do we want this to run on every PR? I thought we'd relegated benchmarks to the overnight runs.
.github/workflows/benchmarks_new.yml
Outdated
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "stable" | ||
| # Run benchmark with `go test -bench` and stores the output to a file |
There was a problem hiding this comment.
I don't see anywhere we use go test -bench, which means we probably don't need to setup go.
.github/workflows/benchmarks_new.yml
Outdated
| - name: Download previous benchmark data | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ./cache | ||
| key: ${{ runner.os }}-benchmark |
There was a problem hiding this comment.
When we were first experimenting with caching our CI pipeline, we determined that using the cache like this is easy but very fragile. Do we care if this has a moderate chance to just fail to retrieve the previous data from cache?
.github/workflows/benchmarks_new.yml
Outdated
| - name: Download previous benchmark data | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ./cache |
There was a problem hiding this comment.
I don't see a step which writes the current benchmark data to the cache anywhere. How is this populated?
There was a problem hiding this comment.
This is still wip not ready for review
typfel
force-pushed
the
jacob/ci/publish-benchmark-results
branch
2 times, most recently
from
86a750b to
db6b8a1
Compare
typfel
force-pushed
the
jacob/ci/publish-benchmark-results
branch
from
db6b8a1 to
e0d2419
Compare
2 participants
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.